-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Bevy 0.8 #205
Update to Bevy 0.8 #205
Conversation
What platform did you test this on? I'm fairly certain it wont work on vulkan due to a WGPU bug. |
Interesting, do you have a link to a bug report? It seems to work on my machine with Vulkan (as mentioned, I'm on Linux/Wayland):
|
Apply minimal changes to make Rust and shader code compile with Bevy 0.8.
Run `cargo update` to update all dependencies to the latest compatible version.
As crevice has been replaced with encase, we can now take care of the min_binding_size TODO.
The View struct definition had significantly deviated from the local copy in tilemap[-atlas].wgsl even before Bevy 0.8 and only ever worked because nothing except for the first field was accessed. Use an #import to ensure that we always get the correct defintion from Bevy itself.
Huh, it might be a windows only thing. Here is the issue I uncovered: I tested this branch specifically and it does not work for me in windows 11, vulkan, and geforce driver 511.79. Dx12 works however. |
Tested this on Windows 10 with Vulkan backend:
Works great, no issues so far. |
Yeah, I discovered the issue was due to a driver bug. Updating my drivers resolved the issue. I likely still wont merge this as we are fairly close to merging the rewrite branch into master and releasing a new version. |
Awesome! Looking forward to the changes in rewrite. Just to confirm, the rewrite branch has support for bevy 0.8? |
Correct! Most of the work is done for the rewrite. I'm mostly working on cleaning up docs. |
This updates all Rust and shader code to work with Bevy 0.8. All examples seem to work fine on my system (Linux Wayland, tested with
--features bevy/wayland
because of bevyengine/bevy#5524).