Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object.observe is dead #82

Closed
warpech opened this issue Nov 2, 2015 · 3 comments
Closed

Object.observe is dead #82

warpech opened this issue Nov 2, 2015 · 3 comments
Assignees

Comments

@warpech
Copy link
Collaborator

warpech commented Nov 2, 2015

https://esdiscuss.org/topic/an-update-on-object-observe
https://news.ycombinator.com/item?id=10494512

It is a pity that it won't make it to ES7, but we saw it coming.

We will need to remove it from json-patch-duplex.js and fall back to dirty checking (which is already used for JS engines other than V8).

Good news is that our dirty checking was more performant in benchmarks, AFAIK. Also, there is benefit in having the same code for all engines.

@Starcounter-Jack
Copy link
Owner

Just as well. It performed rather poorly. Removing the code will reduce our footprint which is always nice.

Sent from my iPhone

On 2 Nov 2015, at 21:38, Marcin Warpechowski notifications@github.com wrote:

https://esdiscuss.org/topic/an-update-on-object-observe
https://news.ycombinator.com/item?id=10494512

It is a pity that it won't make it to ES7, but we have seen it coming.

We will need to remove it from json-patch-duplex.js and fall back to dirty checking (which is already used for JS engines other than V8).

Good news is that our dirty checking was more performant in benchmarks, AFAIK. Also, there is benefit in having the same code for all engines.


Reply to this email directly or view it on GitHub.

@miyconst miyconst self-assigned this Nov 4, 2015
miyconst pushed a commit that referenced this issue Nov 4, 2015
miyconst pushed a commit that referenced this issue Nov 5, 2015
@miyconst
Copy link
Collaborator

miyconst commented Nov 5, 2015

Dependency on Object.observe is now removed and released as 0.5.5.

@miyconst miyconst closed this as completed Nov 5, 2015
@tomalec
Copy link
Collaborator

tomalec commented Nov 16, 2015

Just to note, maybe we could give some feedback for Object.observe champion arv/ecmascript-object-observe#25 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants