Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dirty checking should ignore array properties #84

Closed
miyconst opened this issue Nov 4, 2015 · 1 comment
Closed

Dirty checking should ignore array properties #84

miyconst opened this issue Nov 4, 2015 · 1 comment
Assignees
@miyconst
Labels
bug enhancement

Comments

@miyconst
Copy link
Collaborator

miyconst commented Nov 4, 2015

Array properties are not supported by JSON standard, they should be ignored.

This issue appeared because Polymer adds property splices to arrays, which leads to crazy behavior of json-patch.

cc @warpech, @tomalec
@miyconst miyconst self-assigned this Nov 4, 2015
miyconst pushed a commit that referenced this issue Nov 4, 2015
Fix _objectKeys to ignore array properties
bac89d6 
#84
miyconst pushed a commit that referenced this issue Nov 4, 2015
Add ignore array properties test
5e0dca5 
#84
miyconst pushed a commit that referenced this issue Nov 5, 2015
Fix _objectKeys method
7b6c9df 
#84
miyconst pushed a commit that referenced this issue Nov 5, 2015
Update TypeScript version
205d339 
#84
#82
@miyconst
Copy link
Collaborator Author

miyconst commented Nov 5, 2015

Fixed and released as 0.5.5.

@miyconst miyconst closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miyconst miyconst

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miyconst