Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various typos #3973

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Fix various typos #3973

merged 1 commit into from
Nov 10, 2024

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Nov 10, 2024

Description

Found typos via codespell -q 3 -S "*.po,*.pot,*.utf8,*.pdf,*.dat,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js" -L anonymus,dout,ect,inout,lod,ned,normaly,regio,sav,ser,te,tht,ue

Screenshots (if appropriate):

n/a

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

n/a

Test Configuration:

  • Operating system: n/a
  • Graphics Card: n/a

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@luzpaz
Fix various typos
c8aadf0 
Found via `codespell -q 3 -S "*.po,*.pot,*.utf8,*.pdf,*.dat,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js" -L anonymus,dout,ect,inout,lod,ned,normaly,regio,sav,ser,te,tht,ue`
@github-actions GitHub Actions
Copy link

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

Files matching guide/**:

  • Did you remember to update screenshots to match new updates?
  • Did you remember to grammar check in changed part of documentation?

This is an automatically generated QA checklist based on modified files.

alex-w
alex-w approved these changes Nov 10, 2024
View reviewed changes
Copy link
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w added this to the 24.4 milestone Nov 10, 2024
@alex-w alex-w merged commit ccfcadf into Stellarium:master Nov 10, 2024
13 of 14 checks passed
@luzpaz luzpaz deleted the 2024-typos branch November 10, 2024 21:22
gzotti
gzotti reviewed Nov 10, 2024
View reviewed changes
guide/pgfsys-tex4ht.def
@@ -314,7 +314,7 @@
\hbox to#2\bgroup
\hsize=#2\relax
\vbox\bgroup
% though it works, I'm desabling the above mentioned hack to make tex4ht behave with <p> <\p>, because it blurps the positioning
% though it works, I'm disabling the above mentioned hack to make tex4ht behave with <p> <\p>, because it blurps the positioning
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file may better be reported at their original place, and we might want to update this as well after so many years (and check if it works better now...).

gzotti
gzotti reviewed Nov 10, 2024
View reviewed changes
src/core/modules/Nebula.hpp
@@ -125,7 +125,7 @@ friend class NebulaMgr;
NebEMO = 20, //!< Emission object
NebBLL = 21, //!< BL Lac object
NebBLA = 22, //!< Blazar
NebMolCld = 23, //!< Molecular Cloud
NebMolCld = 23, //!< Molecular Cloud
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least this looks worse now on Github.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So weird, in vscode it looks correct
Screenshot_20241221_071003

But in github, no
https://github.com/luzpaz/stellarium/blob/80b9db83a3f3e374ea35b76d15da64baf4e43c2f/src/core/modules/Nebula.hpp#L128

Copy link
Contributor

@10110111 10110111 Dec 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because tabs shouldn't be used after the first non-whitespace character. They should only be used for indentation (not even alignment!).
To clarify, the reason of the difference is the different tab size: e.g. 8 vs 4 spaces.

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Nov 18, 2024
@github-actions GitHub Actions
Copy link

Hello @luzpaz!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

luzpaz added a commit to luzpaz/stellarium that referenced this pull request Dec 21, 2024
@luzpaz
Fix whitespace anomaly introduced in Stellarium#3973
762a899
alex-w pushed a commit that referenced this pull request Dec 21, 2024
@luzpaz
Fix various typos (#4015)
091b232 
* Fix various typos
Found via`codespell -q 3 -S "*.po,*.pot,*.utf8,*.pdf,*.dat,*.svg,ChangeLog,./src/external,./plugins/RemoteControl/webroot/js,./src/core/planetsephems,./data/org.stellarium.Stellarium.*" -L anonymus,anser,dout,ect,empress,fo,inout,lod,mane,nam,nd,ned,normaly,parana,regio,sav,ser,sting,subtiles,te,tesselate,tesselated,,tesselates,tht,ue`

* Fix whitespace anomaly introduced in #3973
@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Dec 22, 2024
@github-actions GitHub Actions
Copy link

Hello @luzpaz!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzotti gzotti gzotti left review comments

@alex-w alex-w alex-w approved these changes

@10110111 10110111 Awaiting requested review from 10110111

Assignees

@luzpaz luzpaz

Labels
None yet
Milestone
24.4
Development

Successfully merging this pull request may close these issues.
4 participants
@luzpaz @alex-w @10110111 @gzotti