adding namespace support for map saving #613
Conversation
|
@SteveMacenski Can this fix be merged? Users are continuing to run into this issue. |
|
@hilary-luo I believe I left this asking someone experiencing this issue to test this PR to make sure it resolves their issues (to make sure there aren't other problems afoot as well). If someone tests this for that situation and gives it the thumbs up, I can merge and backport for a release! Folks commented in #607 but didn't give me an indication that they tested (and then fell off my radar, as most of my work is event-driven) |
|
Thanks Steve. @NachtaktiverHalbaffe are you able to test this? |
|
Sorry for the late reply. I'll try to test this when im back at University where my setup is located (Problem occured in my master thesis). Cant give a time estimation because I have to setup a completly new workspace/Docker environment (will be an humble environment because TB4 etc. runs on humble) to seperate everything from the current working setup. Try to get this done this month, have to fulfill some other deadlines for my thesis though and this topic isnt a top priority for my supervisor because he is already satisfied with the current workaround |
|
@SteveMacenski This fix worked for me, can we have this merged in? Thanks again |
|
Done |
* Optional map saver (#633) * Add parameter to stop map saver from being initialised Map saver will subscribe to the map topic and force updates of the map even when nothing else is subscribed. This allows it to be turned off to save processing cycles. * Add details of use_map_saver parameter to README * Add defaulted-true use_map_saver parameter to launch configs --------- Co-authored-by: James Ward <j.ward@sydney.edu.au> * adding namespace support for map saving (#613) * fix mismatched service name in rviz plugin (#634) * bumping to 2.6.6 for release --------- Co-authored-by: James Ward <james@robomo.co> Co-authored-by: James Ward <j.ward@sydney.edu.au> Co-authored-by: gene.su <47352191+gene-su@users.noreply.github.com>
* Optional map saver (#633) * Add parameter to stop map saver from being initialised Map saver will subscribe to the map topic and force updates of the map even when nothing else is subscribed. This allows it to be turned off to save processing cycles. * Add details of use_map_saver parameter to README * Add defaulted-true use_map_saver parameter to launch configs --------- Co-authored-by: James Ward <j.ward@sydney.edu.au> * adding namespace support for map saving (#613) * fix mismatched service name in rviz plugin (#634) * bumping iron to 2.7.2 for release --------- Co-authored-by: James Ward <james@robomo.co> Co-authored-by: James Ward <j.ward@sydney.edu.au> Co-authored-by: gene.su <47352191+gene-su@users.noreply.github.com>
Per #607