Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mismatched service name in rviz plugin #634

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

gene-su
Copy link
Contributor

@gene-su gene-su commented Sep 21, 2023


Basic Info

Info Please fill out this column
Ticket(s) this addresses (add tickets here #1)
Primary OS tested on (Ubuntu, MacOS, Windows)
Robotic platform tested on (Steve's Robot, gazebo simulation of Tally, hardware turtlebot)

Description of contribution in a few bullet points

  • Merge Map Tool in Slam Toolbox Plugin is calling wrong services.

Description of documentation updates required from your changes


Future work that may be required in bullet points

@SteveMacenski SteveMacenski merged commit b0c59eb into SteveMacenski:ros2 Sep 21, 2023
SteveMacenski added a commit that referenced this pull request Sep 25, 2023
* Optional map saver (#633)

* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <j.ward@sydney.edu.au>

* adding namespace support for map saving (#613)

* fix mismatched service name in rviz plugin (#634)

* bumping to 2.6.6 for release

---------

Co-authored-by: James Ward <james@robomo.co>
Co-authored-by: James Ward <j.ward@sydney.edu.au>
Co-authored-by: gene.su <47352191+gene-su@users.noreply.github.com>
SteveMacenski added a commit that referenced this pull request Sep 25, 2023
* Optional map saver (#633)

* Add parameter to stop map saver from being initialised

Map saver will subscribe to the map topic and force updates of the map
even when nothing else is subscribed.
This allows it to be turned off to save processing cycles.

* Add details of use_map_saver parameter to README

* Add defaulted-true use_map_saver parameter to launch configs

---------

Co-authored-by: James Ward <j.ward@sydney.edu.au>

* adding namespace support for map saving (#613)

* fix mismatched service name in rviz plugin (#634)

* bumping iron to 2.7.2 for release

---------

Co-authored-by: James Ward <james@robomo.co>
Co-authored-by: James Ward <j.ward@sydney.edu.au>
Co-authored-by: gene.su <47352191+gene-su@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants