Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documents generated through the stamp tool are named FILENAME_watermarked.pdf #757

Closed
provelo-ict opened this issue Jan 30, 2024 · 6 comments · Fixed by #794
Closed

Documents generated through the stamp tool are named FILENAME_watermarked.pdf #757

provelo-ict opened this issue Jan 30, 2024 · 6 comments · Fixed by #794
Assignees
@mannam11
Labels
Bug Something isn't working good first issue Good for newcomers

Comments

@provelo-ict
Copy link

Not a big deal, but maybe they could be named FILENAME_stamped.pdf to differentiate with the watermark tool ?

Also, it would be nice to be able to customize that last part?
Or maybe to use the locale the user has chosen to adapt it?
@provelo-ict provelo-ict changed the title Documents generated through the stamp tool are name FILENAME_watermarked.pdf Documents generated through the stamp tool are named FILENAME_watermarked.pdf Jan 30, 2024
@Frooodle
Copy link
Member

This is a bug and will be fixed next update thanks!

@Frooodle Frooodle added the Bug Something isn't working label Jan 30, 2024
@Frooodle
Copy link
Member

As for locale.. no plan for now but good idea

@sbplat sbplat added the good first issue Good for newcomers label Jan 31, 2024
@mannam11
Copy link
Contributor

mannam11 commented Feb 8, 2024

@sbplat is it still a issue. Can you assign this to me.

@sbplat
Copy link
Member

sbplat commented Feb 8, 2024

Sure

@mannam11 mannam11 mentioned this issue Feb 9, 2024
Merged
4 tasks
@mannam11
Copy link
Contributor

mannam11 commented Feb 9, 2024

@sbplat @Frooodle I have created a PR for to fix this. Can you please review it.

@Frooodle
Copy link
Member

Fixed in upcoming release

Frooodle added a commit that referenced this issue Feb 10, 2024
@Frooodle
Merge pull request #794 from mannam11/fixed-stamptool-wrong-filename-…
7a9417a 
…generaion-#757

fixed wrong filename generation through stamp tool #757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mannam11 mannam11

Labels
Bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed wrong filename generation through stamp tool #757
4 participants
@provelo-ict @sbplat @Frooodle @mannam11