fixed wrong filename generation through stamp tool #757 #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbplat
approved these changes
Feb 9, 2024
|
Please complete the checklist as well, thanks! |
|
@sbplat I have reviewed and completed the checklist |
|
ahh some conflicts now sorry could you resolve |
|
@Frooodle did some changes but its broke. |
|
No problem, let me fix :) |
Frooodle
approved these changes
Feb 10, 2024
| @@ -88,6 +88,45 @@ public ResponseEntity<byte[]> addStamp(@ModelAttribute AddStampRequest request) | |||
| // Load the input PDF | |||
| PDDocument document = Loader.loadPDF(pdfFile.getBytes()); | |||
|
|
|||
| for (PDPage page : document.getPages()) { | |||
There was a problem hiding this comment.
Duplicated code due to code merge I think?
|
Thanks @Frooodle |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #757
Checklist:
Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)