Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stoprint refactor –– mock data (part 3) #6078

Merged
merged 22 commits into from
Jun 2, 2022
Merged

stoprint refactor –– mock data (part 3) #6078

merged 22 commits into from
Jun 2, 2022

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented May 23, 2022 •
edited
Loading

view without whitespace

Noteworthy:

  • DebugNoticeButton navigation bar button
    • definition for component (909dfa6)
    • adding it to navigation (a565ade)
  • Mocked data for stoprint/papercut
  • Load stoprint printers list by removing additional callback (50a0c95)
  • Mark a stoprint 'success' type as boolean instead of as true (975adc1)
  • Pull username from the keychain instead of from navigation params (22233b4)
    • this is the same issue and fix that Hannes fixed three years ago in a separate PR that fixed releaseJob, whereas this fixes cancelJob Fix stoprint release #3730

    • we we were trying to extract the username from the navigation params rather than loading them using loadLoginCredentials. I guess this never got updated when we moved away from storing login credentials in redux itself.

Todo:

  • decide if errors should be undefined or null
  • add debug icon to printer view (it is using mocked data)
  • (optional:) add feature flag system/overrides to enable/disable mocked data instead of single boolean?

Screenshots

Basic Flow

See Jobs Select Printer for Job Release or Cancel Job
see jobs select a printer release or cancel

Alerts

Before Printing After Successful Print Before Canceling After Successful Cancel
before cancel N/A before release N/A
Mock Data Notice General Error
debug notice error

Other States

No Print Jobs Error (can't connect to API) Logged out
no jobs connection issue login

@drewvolz
update counts, errors, problems
4208f29
@drewvolz
Merge branch 'drew/stoprint-part-2' of https://github.com/StoDevX/AAO…
4db603d 
…-React-Native into drew/stoprint-part-2

# Conflicts:
#	eslint-problems
#	tsc-counts
#	tsc-errors
@drewvolz
replace any with void for updatePrinters
c0d8f9f
@drewvolz
fix dispatch not being called in updatePrinters
50a0c95
@drewvolz
mark error as possibly null instead of undefined
f725f57
@drewvolz
add DebugNotice button to navigation buttons
909dfa6 
a button to serve as a visual identifier of views serving up data that
is mocked
@drewvolz
add debug button to views showing mock stoprint data
a565ade
@drewvolz
add mock stoprint endpoints and mock data
e511ff2
@drewvolz
use the mock data endpoints for stoprint in debug
adab212
@drewvolz
fix a stoprint type for success
975adc1
@drewvolz
add mocked stoprint check to redux updatePrinters and updatePrintJobs
564ad50
@drewvolz
add mocked stoprint checks when checking login status
7324ffe
@drewvolz
define printjobs error to be possibly undefined instead of null
2e6674e
@drewvolz
add username from login credentials instead of from navigation params
22233b4 
this is the same issue and fix that Hannes fix three years ago in a
separate PR that fixed releaseJob, whereas this fixes cancelJob
#3730

we we were trying to extract the username from the navigation params
rather than loading them using loadLoginCredentials. I guess this never
got updated when we moved away from storing login credentials in redux
itself.
@drewvolz
add mock data loading to the heldJob function
d89a0f0 
* prevent login checking if we are serving up mocked data
* branch to fetch mock data from fetching production data
* depend upon printer object because properties may be undefined
@drewvolz
ensure that the printer object is not undefined in print release views
dc654ed
@drewvolz
update counts, problems, and errors
c1b9eb3
@drewvolz drewvolz mentioned this pull request May 24, 2022
Merged
@drewvolz drewvolz merged commit 2f941e5 into drew/stoprint-part-2 Jun 2, 2022
@drewvolz drewvolz deleted the drew/stoprint-part-3 branch June 2, 2022 02:18
@drewvolz drewvolz mentioned this pull request Jul 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkrives hawkrives Awaiting requested review from hawkrives

@rye rye Awaiting requested review from rye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@drewvolz