Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stoprint refactor –– mock data (part 3) #6078

Merged
merged 22 commits into from
Jun 2, 2022
Merged

stoprint refactor –– mock data (part 3) #6078

merged 22 commits into from
Jun 2, 2022

Commits on May 20, 2022

  1. update counts, errors, problems

    @drewvolz
    drewvolz committed May 20, 2022
    Configuration menu
    Copy the full SHA
    4208f29 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2022

  1. Merge branch 'drew/stoprint-part-2' of https://github.com/StoDevX/AAO… 

    …-React-Native into drew/stoprint-part-2

# Conflicts:
#	eslint-problems
#	tsc-counts
#	tsc-errors
    @drewvolz
    drewvolz committed May 22, 2022
    Configuration menu
    Copy the full SHA
    4db603d View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. replace any with void for updatePrinters

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    c0d8f9f View commit details
    Browse the repository at this point in the history

  2. fix dispatch not being called in updatePrinters

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    50a0c95 View commit details
    Browse the repository at this point in the history

  3. mark error as possibly null instead of undefined

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    f725f57 View commit details
    Browse the repository at this point in the history

  4. add DebugNotice button to navigation buttons 

    a button to serve as a visual identifier of views serving up data that
is mocked
    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    909dfa6 View commit details
    Browse the repository at this point in the history

  5. add debug button to views showing mock stoprint data

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    a565ade View commit details
    Browse the repository at this point in the history

  6. add mock stoprint endpoints and mock data

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    e511ff2 View commit details
    Browse the repository at this point in the history

  7. use the mock data endpoints for stoprint in debug

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    adab212 View commit details
    Browse the repository at this point in the history

  8. fix a stoprint type for success

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    975adc1 View commit details
    Browse the repository at this point in the history

  9. add mocked stoprint check to redux updatePrinters and updatePrintJobs

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    564ad50 View commit details
    Browse the repository at this point in the history

  10. add mocked stoprint checks when checking login status

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    7324ffe View commit details
    Browse the repository at this point in the history

  11. define printjobs error to be possibly undefined instead of null

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    2e6674e View commit details
    Browse the repository at this point in the history

  12. add username from login credentials instead of from navigation params 

    this is the same issue and fix that Hannes fix three years ago in a
separate PR that fixed releaseJob, whereas this fixes cancelJob
#3730

we we were trying to extract the username from the navigation params
rather than loading them using loadLoginCredentials. I guess this never
got updated when we moved away from storing login credentials in redux
itself.
    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    22233b4 View commit details
    Browse the repository at this point in the history

  13. add mock data loading to the heldJob function 

    * prevent login checking if we are serving up mocked data
* branch to fetch mock data from fetching production data
* depend upon printer object because properties may be undefined
    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    d89a0f0 View commit details
    Browse the repository at this point in the history

  14. ensure that the printer object is not undefined in print release views

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    dc654ed View commit details
    Browse the repository at this point in the history

  15. update counts, problems, and errors

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    c1b9eb3 View commit details
    Browse the repository at this point in the history

  16. remove unused and commented out functions

    @drewvolz
    drewvolz committed May 23, 2022
    Configuration menu
    Copy the full SHA
    66cd1f0 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. add debug notice to mocked stoprint list of printers

    @drewvolz
    drewvolz committed May 24, 2022
    Configuration menu
    Copy the full SHA
    3116fa1 View commit details
    Browse the repository at this point in the history

  2. remove TS2532 (again) by setting print job error types to string or null

    @drewvolz
    drewvolz committed May 24, 2022
    Configuration menu
    Copy the full SHA
    352cc05 View commit details
    Browse the repository at this point in the history

  3. update counts, problems, and errors

    @drewvolz
    drewvolz committed May 24, 2022
    Configuration menu
    Copy the full SHA
    f84e7e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. turn off mocked stoprint setting

    @drewvolz
    drewvolz committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    e32c8b0 View commit details
    Browse the repository at this point in the history