Skip to content

Commit

Permalink
Fixed bug in import path CI (#919)
Browse files Browse the repository at this point in the history
Closes: #XXX

## Context and purpose of the change
The automated module versioning action was failing due to a permission error from the docker volume mount. This PR modifies the makefile command to to pass the same user/group from the underlying system so docker has permission to write.

## Brief Changelog
* Specified user during proto-gen command
* Bumped proto version
* Updated gaia submodule (unrelated to this PR but version on main was incorrect)

## Testing
Verified on separate branch. Will need to merge this before we can do a final test though.

## Author's Checklist

I have...

- [ ] Run and PASSED locally all GAIA integration tests
- [ ] If the change is contentful, I either:
    - [ ] Added a new unit test OR 
    - [ ] Added test cases to existing unit tests
- [X] OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.


## Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] manually tested (if applicable)
- [ ] confirmed the author wrote unit tests for new logic
- [ ] reviewed documentation exists and is accurate


## Documentation and Release Note

  - [ ] Does this pull request introduce a new feature or user-facing behavior changes? 
  - [ ] Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`?
  - [ ] This pull request updates existing proto field values (and require a backend and frontend migration)? 
  - [ ] Does this pull request change existing proto field names (and require a frontend migration)?
  How is the feature or change documented? 
      - [ ] not applicable
      - [ ] jira ticket `XXX` 
      - [ ] specification (`x/<module>/spec/`) 
      - [ ] README.md 
      - [ ] not documented
  • Loading branch information
sampocs committed Sep 5, 2023
1 parent 52581d2 commit 377bd3c
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 3 deletions.
15 changes: 15 additions & 0 deletions .github/workflows/version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,21 @@ jobs:
if: ${{ steps.push.outcome == 'failure' }}
run: |
echo "Push failed. The token might be expired or have insufficient permissions. Please check your token."
echo "The token can be found in the 'dev-stride' account. To view the token, login to 'dev-stride' and go to:"
echo " -> Profile"
echo " -> Settings"
echo " -> Developer Settings"
echo " -> Personal Access Tokens"
echo " -> Tokens (classic)"
echo " -> 'GH Actions' Token"
echo ""
echo "If the token is expired, you can click on the token and then select 'Regenerate Token'"
echo "After regenerating a new token, you'll have to update the 'GH_ACTIONS_PAT' environment variable:"
echo " -> Navigate to the stride repo"
echo " -> Settings"
echo " -> Secrets and variables"
echo " -> Actions"
echo " -> Then modify 'GH_ACTIONS_PAT'"
exit 1
- name: Fetch New Branch
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -164,14 +164,14 @@ stop-local-to-main:
### Protobuf ###
###############################################################################

containerProtoVer=0.13.0
containerProtoVer=0.14.0
containerProtoImage=ghcr.io/cosmos/proto-builder:$(containerProtoVer)

proto-all: proto-format proto-lint proto-gen

proto-gen:
@echo "Generating Protobuf files"
@$(DOCKER) run --rm -v $(CURDIR):/workspace --workdir /workspace $(containerProtoImage) \
@$(DOCKER) run --user $(id -u):$(id -g) --rm -v $(CURDIR):/workspace --workdir /workspace $(containerProtoImage) \
sh ./scripts/protocgen.sh;

proto-format:
Expand Down
2 changes: 1 addition & 1 deletion deps/gaia
Submodule gaia updated 220 files

0 comments on commit 377bd3c

Please sign in to comment.