Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in import path CI #919

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Fixed bug in import path CI #919

merged 4 commits into from
Sep 5, 2023

Conversation

sampocs
Copy link
Collaborator

@sampocs sampocs commented Sep 5, 2023

Closes: #XXX

Context and purpose of the change

The automated module versioning action was failing due to a permission error from the docker volume mount. This PR modifies the makefile command to to pass the same user/group from the underlying system so docker has permission to write.

Brief Changelog

  • Specified user during proto-gen command
  • Bumped proto version
  • Updated gaia submodule (unrelated to this PR but version on main was incorrect)

Testing

Verified on separate branch. Will need to merge this before we can do a final test though.

Author's Checklist

I have...

  • Run and PASSED locally all GAIA integration tests
  • If the change is contentful, I either:
    • Added a new unit test OR
    • Added test cases to existing unit tests
  • OR this change is a trivial rework / code cleanup without any test coverage

If skipped any of the tests above, explain.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • reviewed state machine logic
  • reviewed API design and naming
  • manually tested (if applicable)
  • confirmed the author wrote unit tests for new logic
  • reviewed documentation exists and is accurate

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes?
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md?
  • This pull request updates existing proto field values (and require a backend and frontend migration)?
  • Does this pull request change existing proto field names (and require a frontend migration)?
    How is the feature or change documented?
    • not applicable
    • jira ticket XXX
    • specification (x/<module>/spec/)
    • README.md
    • not documented

@github-actions github-actions bot added the T:CI label Sep 5, 2023
@sampocs sampocs added the A:automerge Automatically merge PR once checks pass label Sep 5, 2023
@mergify mergify bot merged commit 377bd3c into main Sep 5, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once checks pass C:submodules T:build T:CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants