-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V17 upgrade handler #1029
V17 upgrade handler #1029
Conversation
…nto v17-upgrade-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking quite good! Some small fixes we need to make, nothing major.
Also waiting to approve as I think we're still missing:
(1) submit ICA to disable tokenize shares
(2) bank send for shade.
Registered community pool liquid staking ICA addresses and module addresses
lgtm
Deleted all pending slash queries
lgtm
Reset slash query in progress flag
lgtm
Increased the community pool tax
LGTM. Checked it's represented as a decimal in distribution params. New value and IncreaseCommunityPoolTax
look good.
Adjusted the redemption rate bounds
Outer bounds lgtm. Osmosis buffer lgtm. Only question is why are we setting the inner bounds in the upgrade handler?
Updated the rate limit thresholds
Need some changes to the percentages per PR comments. Otherwise lgtm.
Added rate limits to osmosis
Looks good for Osmosis, but should we RL other DEXs too?
Co-authored-by: riley-stride <104941670+riley-stride@users.noreply.github.com>
…nto v17-upgrade-handler
Note we also need to add the PFM store key. Added a TODO list to the description. |
Co-authored-by: sampocs <sam.pochyly@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few small comments, otherwise lgtm!
Checking back in on this one, I think the last few tasks (besides addressing PR comments) are:
I've seen some of these in other PRs. Would recommend we get them all merged into here so we have a full final upgrade handler before we sign off on it. |
Co-authored-by: sampocs <sam.pochyly@gmail.com>
…nto v17-upgrade-handler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the shade prop, the pfm store key and the ica for preventing tokenization on the hub.
Approved!
Closes #1003
Context
Upgrade handler for v17 upgrade
Note to reviewer: Please pay attention to all constants/string literals and make sure there's no typos in the chain IDs, redemption rate adjustments, rate limit thresholds, etc.
Changelog