GumGum: passes bid response's currency unit (prebid#4757)

* pass us privacy consent string to request * passes bid response currency * adds test for passing bid response currency
SublimeSkinz · Mar 5, 2020 · d957637 · d957637
1 parent ea5c922
commit d957637
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 15 deletions.
diff --git a/modules/gumgumBidAdapter.js b/modules/gumgumBidAdapter.js
@@ -244,7 +244,8 @@ function interpretResponse (serverResponse, bidRequest) {
     ad: {
       price: cpm,
       id: creativeId,
-      markup
+      markup,
+      cur
     },
     cw: wrapper,
     pag: {
@@ -273,7 +274,7 @@ function interpretResponse (serverResponse, bidRequest) {
       ad: wrapper ? getWrapperCode(wrapper, Object.assign({}, serverResponseBody, { bidRequest })) : markup,
       cpm: isTestUnit ? 0.1 : cpm,
       creativeId,
-      currency: 'USD',
+      currency: cur || 'USD',
       height,
       netRevenue: true,
       requestId: bidRequest.id,

diff --git a/test/spec/modules/gumgumBidAdapter_spec.js b/test/spec/modules/gumgumBidAdapter_spec.js
@@ -230,24 +230,33 @@ describe('gumgumAdapter', function () {
       method: 'GET',
       pi: 3
     }
+    let expectedResponse = {
+      'ad': '<html><h3>I am an ad</h3></html>',
+      'cpm': 0,
+      'creativeId': 29593,
+      'currency': 'USD',
+      'height': '250',
+      'netRevenue': true,
+      'requestId': 12345,
+      'width': '300',
+      // dealId: DEAL_ID,
+      // referrer: REFERER,
+      ttl: 60
+    };
 
     it('should get correct bid response', function () {
-      let expectedResponse = {
-        'ad': '<html><h3>I am an ad</h3></html>',
-        'cpm': 0,
-        'creativeId': 29593,
-        'currency': 'USD',
-        'height': '250',
-        'netRevenue': true,
-        'requestId': 12345,
-        'width': '300',
-        // dealId: DEAL_ID,
-        // referrer: REFERER,
-        ttl: 60
-      };
       expect(spec.interpretResponse({ body: serverResponse }, bidRequest)).to.deep.equal([expectedResponse]);
     });
 
+    it('should pass correct currency if found in bid response', function () {
+      const cur = 'EURO';
+      let response = Object.assign({}, serverResponse);
+      let expected = Object.assign({}, expectedResponse);
+      response.ad.cur = cur;
+      expected.currency = cur;
+      expect(spec.interpretResponse({ body: response }, bidRequest)).to.deep.equal([expected]);
+    });
+
     it('handles nobid responses', function () {
       let response = {
         'ad': {},