Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GumGum: passes bid response's currency unit #4757

Merged
merged 5 commits into from
Jan 23, 2020
Merged

Conversation

susyt
Copy link
Contributor

@susyt susyt commented Jan 17, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Currency was hardcoded to 'USD' because the bid responses previously did not contain the currency unit. Now that the bid responses are sending the currency unit, the adapter needs to be updated to pass the bid response's currency unit.

@harpere harpere self-assigned this Jan 22, 2020
@harpere harpere merged commit 4bca612 into prebid:master Jan 23, 2020
hellsingblack pushed a commit to SublimeSkinz/Prebid.js that referenced this pull request Mar 5, 2020
* pass us privacy consent string to request

* passes bid response currency

* adds test for passing bid response currency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants