Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logs available on task endpoint #824

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: logs available on task endpoint #824

merged 1 commit into from
Feb 16, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 14, 2024

Description

Fixes FL-1285

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

Copy link

linear bot commented Feb 14, 2024

@SdgJlbl SdgJlbl changed the base branch from main to feat/add-new-compute-tasks-status-linked-to-function-status February 14, 2024 15:43
@SdgJlbl SdgJlbl changed the title Feat/logs from task feat: logs available on task endpoint Feb 14, 2024
@ThibaultFy
Copy link
Member

ThibaultFy commented Feb 14, 2024

I don't see the changes you applied here Substra/substra#398 for the log address.
Also, you mention that it fixes FL-1285 but is it really the case ?

Base automatically changed from feat/add-new-compute-tasks-status-linked-to-function-status to main February 15, 2024 16:28
@SdgJlbl
Copy link
Contributor Author

SdgJlbl commented Feb 15, 2024

I don't see the changes you applied here Substra/substra#398 for the log address.

I'm not sure I understand what you mean. The urls have been updated 🤔

Also, you mention that it fixes FL-1285 but is it really the case ?

Yes, it's fixing the final skipped test case 💪

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✍️

@ThibaultFy
Copy link
Member

I'm not sure I understand what you mean. The urls have been updated 🤔

Ah ok I thought the url was set on the backend too, sorry :)

@SdgJlbl SdgJlbl merged commit fd92c7f into main Feb 16, 2024
8 checks passed
@SdgJlbl SdgJlbl deleted the feat/logs-from-task branch February 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants