Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change logs endpoint #298

Merged
merged 1 commit into from
Feb 16, 2024
Merged

feat: change logs endpoint #298

merged 1 commit into from
Feb 16, 2024

Conversation

SdgJlbl
Copy link
Contributor

@SdgJlbl SdgJlbl commented Feb 15, 2024

Companion PR Substra/substra-backend#824

Description

How to test

Screenshots

Notes for developers and reviewers:

  • Think to update CHANGELOG.md before merge if needed !

@SdgJlbl SdgJlbl requested review from HamdyD, jmorel and a team as code owners February 15, 2024 15:37
Copy link
Member

@ThibaultFy ThibaultFy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)
One comment unless I'm mistaken

src/routes/tasks/components/ErrorAlert.tsx Outdated Show resolved Hide resolved
@SdgJlbl SdgJlbl force-pushed the feat/donwload-logs branch 2 times, most recently from 06d1f0f to ea8bce7 Compare February 15, 2024 16:20
Copy link
Contributor

@guilhem-barthes guilhem-barthes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✍️

Signed-off-by: SdgJlbl <sarah.diot-girard@owkin.com>
@SdgJlbl SdgJlbl merged commit 36d9100 into main Feb 16, 2024
3 checks passed
@SdgJlbl SdgJlbl deleted the feat/donwload-logs branch February 16, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants