Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up package now that full mode is vectorized #86

Merged
merged 14 commits into from
Nov 1, 2019
Merged

Clean up package now that full mode is vectorized #86

merged 14 commits into from
Nov 1, 2019

Conversation

anomam
Copy link
Contributor

@anomam anomam commented Oct 31, 2019 •
edited
Loading

  • no need for the view matrix
  • no need for view factor mapping
  • also remove surface registry methods
  • no need for ordered PV array transform method
  • create TsShadeCollection to unify ground and pv rows APIs a little more
  • make sure docs build well and correctly

It would be a good idea to reorganize the geometry subpackage, because some of the modules contain to much code and too many classes (next PR most likely).

@anomam anomam added the WIP Work in progress label Oct 31, 2019
@anomam anomam self-assigned this Oct 31, 2019
@anomam anomam removed the WIP Work in progress label Nov 1, 2019
@anomam anomam merged commit bc6bc36 into master Nov 1, 2019
@anomam anomam deleted the clean_up branch November 1, 2019 07:51
@anomam anomam mentioned this pull request Nov 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@anomam anomam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anomam