Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up package now that full mode is vectorized #86

Merged
merged 14 commits into from
Nov 1, 2019
Merged

Clean up package now that full mode is vectorized #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
0a21ca6
Remove view matrix methods & instant vf matrix calculation as well
Oct 31, 2019
b705621
Remove old view factor calculation mapper since no more view matrix
Oct 31, 2019
106f554
Remove surface registry stuff & unused properties and methods
Oct 31, 2019
c0ba797
Start removing transform method of PV array
Oct 31, 2019
2e532cb
Lots of updates to make tests pv array pass, still 1 failing
Nov 1, 2019
311e94d
Fixed last failing test for pv array: now can query params as usual
Nov 1, 2019
03c05f8
Introducing TsShadeCollection to unify ground and pv rows some more
Nov 1, 2019
ab79c7e
Finally fixed all irradiance model tests
Nov 1, 2019
3591fff
Fix vf calculator tests
Nov 1, 2019
e691b15
Clean up TsShadeCollection
Nov 1, 2019
97be2dd
Clean up docs API section
Nov 1, 2019
90e5e95
Rename module to fix docs issues
Nov 1, 2019
f4fd919
Forgot to add module
Nov 1, 2019
079079c
Some clean up
Nov 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/sphinx/developer/geometry.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ timeseries
timeseries.TsPVRow
timeseries.TsGround
timeseries.TsSide
timeseries.TsDualSegment
timeseries.TsSegment
timeseries.TsShadeCollection
timeseries.TsSurface
timeseries.TsLineCoords
timeseries.TsPointCoords
9 changes: 4 additions & 5 deletions docs/sphinx/developer/viewfactors.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,17 +19,16 @@ calculator
:nosignatures:

calculator.VFCalculator
calculator.VFTsMethods

mapper
^^^^^^
methods
^^^^^^^

.. automodule:: mapper
.. automodule:: methods
:no-members:
:no-inherited-members:

.. autosummary::
:toctree: generated/
:nosignatures:

mapper.VFMapperOrderedPVArray
methods.VFTsMethods
20 changes: 0 additions & 20 deletions pvfactors/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
"""This module contains the default values and constants used in pvfactors """
from future.utils import iteritems
import numpy as np

# Geometry params
Expand Down Expand Up @@ -32,25 +31,6 @@
THRESHOLD_DISTANCE_TOO_CLOSE = 1e-10


# The view dictionaries associate integer indices to 'types' of views. For
# instance "ground_sky" would be the view between a ground surface and the
# sky, and it would use the integer index ``1``.
VIEW_DICT = {
None: 0,
"ground_sky": 1,
"back_gnd": 2,
"gnd_back": 3,
"front_sky": 4,
"back_sky": 5,
"back_gnd_obst": 6,
"gnd_back_obst": 7,
"front_gnd_obst": 8,
"gnd_front_obst": 9,
"pvrows": 10}
REVERSE_VIEW_DICT = {v: k for (k, v) in iteritems(VIEW_DICT)}
THRESHOLD_VF_12 = 5e-5


# Gaussian shading default parameters: TOTAL_GAUSSIAN_AREA dependent on these
SIGMA = 1. / np.sqrt(2.)
N_SIGMA = 3.
Expand Down
6 changes: 3 additions & 3 deletions pvfactors/engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@


class PVEngine(object):
"""Class putting all of the calculations together, and able to run it
as a timeseries when the pvarrays can be build from dictionary parameters
"""Class putting all of the calculations together into simple
workflows.
"""

def __init__(self, pvarray, vf_calculator=None, irradiance_model=None,
Expand Down Expand Up @@ -254,7 +254,7 @@ def _calculate_back_ts_segment_qinc(self, ts_segment, pvrow_idx):
"""

# Get all timeseries surfaces in segment
list_ts_surfaces = [ts_segment.illum, ts_segment.shaded]
list_ts_surfaces = ts_segment.all_ts_surfaces

# Get irradiance vectors for calculation
albedo = self.irradiance.albedo
Expand Down
Loading