Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elizabeth/test ai #11

Closed
wants to merge 31 commits into from
Closed

Elizabeth/test ai #11

wants to merge 31 commits into from

Conversation

eschutho
Copy link

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

hugosjoberg and others added 28 commits September 20, 2023 17:06
@hugosjoberg @eschutho
fix(dockefile): broken docker image (apache#25251)
dbb7acd
@hughhhh @eschutho
feat: Tags ListView Page (apache#24964)
39ec061
@kgabryje @eschutho
fix: Add line height to metadata bar (apache#25268)
0db07d1
@eschutho
fix: inability to remove chart filter when dashboard time filter is a…
574147e 
…pplied (apache#25217)
@dependabot @eschutho
build(deps-dev): bump eslint from 8.48.0 to 8.49.0 in /superset-webso…
b5a15d0 
…cket (apache#25263)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@john-bodley @eschutho
chore: Remove the ability to switch to filter-box chart when DASHBOAR…
0aa4705 
…D_NATIVE_FILTERS feature is enabled (apache#25275)
@dependabot @eschutho
build(deps): bump uuid from 9.0.0 to 9.0.1 in /superset-websocket (ap…
babdbb2 
…ache#25279)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jsoref @eschutho
docs: rewrite superset docker localhost prose (apache#25296)
b62ff92 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@betodealmeida @eschutho
fix: is_select with UNION (apache#25290)
990dbe7
@dependabot @eschutho
build(deps): bump ws from 8.13.0 to 8.14.1 in /superset-websocket (ap…
aa9d33d 
…ache#25293)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alekseyolg @eschutho
build(docker): bump geckodriver and firefox to latest (apache#25287)
e030395
@Always-prog @eschutho
feat(datasource): Checkbox for always filtering main dttm in datasour…
a38c50a 
…ce (apache#25204)

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
@rusackas @eschutho
chore: changing one word (disablement -> disabling) (apache#25291)
aed3dd4
@justinpark @eschutho
chore(sqllab): Migrate tests to typescript (apache#25274)
3a42300
@dependabot @eschutho
build(deps-dev): bump @types/uuid from 9.0.3 to 9.0.4 in /superset-we…
2bb10e1 
…bsocket (apache#25311)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@villebro @eschutho
chore: bump gunicorn to v21 (apache#25313)
a9c1262
@john-bodley @eschutho
fix: Add explicit ON DELETE CASCADE for dashboard_roles (apache#25320)
e1f9812
@jbat @eschutho
docs: add ReadyTech to INTHEWILD.md (apache#25324)
b5e1b31
@kgabryje @eschutho
fix(chart): Supporting custom SQL as temporal x-axis column with filt…
65e5ea1 
…er (apache#25126)

Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
@jfrag1 @eschutho
fix: Use RLS clause instead of ID for cache key (apache#25229)
63113d7
@janhavitripurwar @eschutho
docs: add snowflake-sqlalchemy in ./docker/requirements-local.txt (ap…
be79435 
…ache#25312)
@hughhhh @eschutho
feat(tag): fast follow for Tags flatten api + update client with gene…
97fd522 
…rator + some bug fixes (apache#25309)
@tenkian4 @nav-InverseInfinity @eschutho
feat(helm): Support HPA for supersetNode and supersetWorker (apache#2…
2f9d0af 
…5280)

Co-authored-by: Nav_InverseInfinity <naveen.damotharan@outlook.com>
@kravi21 @eschutho
docs: jwks_uri addition to OAUTH provider (apache#24928)
24bd123
@jfrag1 @eschutho
fix: Improve the reliability of alerts & reports (apache#25239)
a78a9c2
@michael-s-molina @eschutho
feat: Adds CLI commands to execute viz migrations (apache#25304)
c63c0c7
@justinpark @eschutho
fix(sqllab): invalid persisted tab state (apache#25308)
e86526e
@michael-s-molina @eschutho
fix: DashboardRoles cascade operation (apache#25349)
cc8c651
eschutho
eschutho commented Sep 21, 2023
View reviewed changes
superset/async_events/async_query_manager_factory.py
# specific language governing permissions and limitations
# under the License.

from flask import Flask
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai Please generate a test plan for this file.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

@eschutho eschutho closed this Sep 21, 2023
@eschutho eschutho reopened this Sep 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

Image description CodeRabbit

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

github-actions[bot]
github-actions bot reviewed Sep 21, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 515452c and e4af715 commits.
Files selected (125)
  • .github/workflows/ai-pr-reviewer.yml (1)
  • .gitignore (1)
  • CHANGELOG.md (1)
  • CONTRIBUTING.md (1)
  • Dockerfile (2)
  • RESOURCES/INTHEWILD.md (1)
  • docker/nginx/nginx.conf (1)
  • docs/docs/contributing/hooks-and-linting.mdx (1)
  • docs/docs/databases/snowflake.mdx (1)
  • docs/docs/installation/configuring-superset.mdx (1)
  • docs/docs/installation/installing-superset-using-docker-compose.mdx (1)
  • helm/superset/README.md (3)
  • requirements/base.txt (1)
  • setup.py (1)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.jsx (1)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.tsx (1)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/QueryStateLabel.test.tsx (1)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/index.tsx (1)
  • superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx (1)
  • superset-frontend/src/components/Datasource/DatasourceEditor.jsx (2)
  • superset-frontend/src/components/Datasource/DatasourceModal.tsx (1)
  • superset-frontend/src/components/ListView/ListView.tsx (11)
  • superset-frontend/src/components/MetadataBar/ContentConfig.tsx (1)
  • superset-frontend/src/components/MetadataBar/ContentType.ts (1)
  • superset-frontend/src/components/MetadataBar/MetadataBar.tsx (1)
  • superset-frontend/src/components/PageHeaderWithActions/index.tsx (3)
  • superset-frontend/src/components/Tags/Tag.tsx (1)
  • superset-frontend/src/dashboard/components/Header/Header.test.tsx (1)
  • superset-frontend/src/explore/actions/exploreActions.test.js (1)
  • superset-frontend/src/explore/actions/saveModalActions.js (2)
  • superset-frontend/src/explore/actions/saveModalActions.test.js (1)
  • superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx (2)
  • superset-frontend/src/explore/reducers/exploreReducer.js (4)
  • superset-frontend/src/features/datasets/types.ts (1)
  • superset-frontend/src/features/tags/BulkTagModal.tsx (1)
  • superset-frontend/src/features/tags/TagModal.test.tsx (2)
  • superset-frontend/src/features/tags/TagModal.tsx (8)
  • superset-frontend/src/features/tags/tags.ts (1)
  • superset-frontend/src/pages/AlertReportList/index.tsx (1)
  • superset-frontend/src/pages/AllEntities/index.tsx (3)
  • superset-frontend/src/pages/AnnotationLayerList/index.tsx (1)
  • superset-frontend/src/pages/AnnotationList/index.tsx (1)
  • superset-frontend/src/pages/ChartCreation/index.tsx (1)
  • superset-frontend/src/pages/ChartList/index.tsx (1)
  • superset-frontend/src/pages/CssTemplateList/index.tsx (1)
  • superset-frontend/src/pages/DashboardList/index.tsx (2)
  • superset-frontend/src/pages/DatabaseList/index.tsx (1)
  • superset-frontend/src/pages/DatasetList/index.tsx (1)
  • superset-frontend/src/pages/ExecutionLogList/index.tsx (2)
  • superset-frontend/src/pages/QueryHistoryList/index.tsx (2)
  • superset-frontend/src/pages/RowLevelSecurityList/index.tsx (1)
  • superset-frontend/src/pages/SavedQueryList/index.tsx (1)
  • superset-frontend/src/pages/Tags/index.tsx (4)
  • superset-frontend/src/views/CRUD/types.ts (1)
  • superset/app.py (2)
  • superset/async_events/api.py (1)
  • superset/async_events/async_query_manager_factory.py (1)
  • superset/charts/data/api.py (2)
  • superset/cli/viz_migrations.py (1)
  • superset/common/query_context_factory.py (3)
  • superset/config.py (3)
  • superset/connectors/sqla/models.py (4)
  • superset/connectors/sqla/views.py (2)
  • superset/daos/tag.py (2)
  • superset/dashboards/schemas.py (1)
  • superset/datasets/api.py (2)
  • superset/datasets/commands/duplicate.py (1)
  • superset/datasets/schemas.py (4)
  • superset/db_engine_specs/README.md (1)
  • superset/db_engine_specs/base.py (1)
  • superset/db_engine_specs/clickhouse.py (1)
  • superset/db_engine_specs/elasticsearch.py (2)
  • superset/db_engine_specs/kusto.py (2)
  • superset/db_engine_specs/lib.py (1)
  • superset/db_engine_specs/solr.py (1)
  • superset/extensions/init.py (2)
  • superset/extensions/ssh.py (3)
  • superset/initialization/init.py (2)
  • superset/migrations/shared/migrate_viz/base.py (3)
  • superset/migrations/versions/2022-07-07_13-00_c747c78868b6_migrating_legacy_treemap.py (2)
  • superset/migrations/versions/2022-07-07_14-00_06e1e70058c7_migrating_legacy_area.py (2)
  • superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py (3)
  • superset/migrations/versions/2023-06-08_09-02_9ba2ce3086e5_migrate_pivot_table_v1_to_v2.py (2)
  • superset/migrations/versions/2023-06-08_10-22_4c5da39be729_migrate_treemap_chart.py (2)
  • superset/migrations/versions/2023-06-08_11-34_ae58e1e58e5c_migrate_dual_line_to_mixed_chart.py (2)
  • superset/migrations/versions/2023-08-09_14-17_8ace289026f3_add_on_delete_cascade_for_dashboard_slices.py (1)
  • superset/migrations/versions/2023-08-09_15-39_4448fa6deeb1__dd_on_delete_cascade_for_embedded_dashboards.py.py (1)
  • superset/migrations/versions/2023-09-06_13-18_317970b4400c_added_time_secondary_column_to_.py (1)
  • superset/migrations/versions/2023-09-15_12-58_4b85906e5b91_add_on_delete_cascade_for_dashboard_roles.py (1)
  • superset/models/dashboard.py (1)
  • superset/models/helpers.py (2)
  • superset/security/manager.py (2)
  • superset/sql_parse.py (1)
  • superset/sqllab/utils.py (2)
  • superset/tags/api.py (8)
  • superset/tags/commands/create.py (3)
  • superset/tags/commands/utils.py (2)
  • superset/tags/exceptions.py (2)
  • superset/tags/schemas.py (1)
  • superset/tasks/cron_util.py (3)
  • superset/tasks/scheduler.py (2)
  • superset/utils/class_utils.py (1)
  • superset/utils/core.py (2)
  • superset/utils/machine_auth.py (3)
  • superset/views/core.py (2)
  • superset/views/datasource/schemas.py (4)
  • superset/views/datasource/views.py (1)
  • tests/integration_tests/charts/data/api_tests.py (10)
  • tests/integration_tests/core_tests.py (3)
  • tests/integration_tests/dashboard_utils.py (1)
  • tests/integration_tests/datasets/api_tests.py (1)
  • tests/integration_tests/datasets/commands_tests.py (2)
  • tests/integration_tests/datasource_tests.py (7)
  • tests/integration_tests/fixtures/importexport.py (2)
  • tests/integration_tests/security/row_level_security_tests.py (1)
  • tests/integration_tests/sql_lab/api_tests.py (1)
  • tests/integration_tests/tags/api_tests.py (3)
  • tests/integration_tests/test_app.py (2)
  • tests/unit_tests/dao/tag_test.py (1)
  • tests/unit_tests/datasets/commands/export_test.py (2)
  • tests/unit_tests/sql_parse_tests.py (1)
  • tests/unit_tests/tags/commands/create_test.py (5)
  • tests/unit_tests/tags/commands/update_test.py (5)
  • tests/unit_tests/tasks/test_cron_util.py (7)
  • tests/unit_tests/utils/test_core.py (2)
Files ignored due to filter (9)
  • docker-compose.yml
  • helm/superset/Chart.yaml
  • helm/superset/templates/deployment-worker.yaml
  • helm/superset/templates/deployment.yaml
  • helm/superset/templates/hpa-node.yaml
  • helm/superset/templates/hpa-worker.yaml
  • helm/superset/values.yaml
  • superset-websocket/package-lock.json
  • superset-websocket/package.json
Files not summarized due to errors (125)
  • CHANGELOG.md (nothing obtained from openai)
  • RESOURCES/INTHEWILD.md (nothing obtained from openai)
  • CONTRIBUTING.md (nothing obtained from openai)
  • Dockerfile (nothing obtained from openai)
  • .github/workflows/ai-pr-reviewer.yml (nothing obtained from openai)
  • .gitignore (nothing obtained from openai)
  • docker/nginx/nginx.conf (nothing obtained from openai)
  • docs/docs/databases/snowflake.mdx (nothing obtained from openai)
  • docs/docs/contributing/hooks-and-linting.mdx (nothing obtained from openai)
  • docs/docs/installation/configuring-superset.mdx (nothing obtained from openai)
  • docs/docs/installation/installing-superset-using-docker-compose.mdx (nothing obtained from openai)
  • helm/superset/README.md (nothing obtained from openai)
  • requirements/base.txt (nothing obtained from openai)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.tsx (nothing obtained from openai)
  • setup.py (nothing obtained from openai)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.jsx (nothing obtained from openai)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/QueryStateLabel.test.tsx (nothing obtained from openai)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/index.tsx (nothing obtained from openai)
  • superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx (nothing obtained from openai)
  • superset-frontend/src/components/Datasource/DatasourceModal.tsx (nothing obtained from openai)
  • superset-frontend/src/components/Datasource/DatasourceEditor.jsx (nothing obtained from openai)
  • superset-frontend/src/components/ListView/ListView.tsx (nothing obtained from openai)
  • superset-frontend/src/components/MetadataBar/ContentConfig.tsx (nothing obtained from openai)
  • superset-frontend/src/components/MetadataBar/ContentType.ts (nothing obtained from openai)
  • superset-frontend/src/components/Tags/Tag.tsx (nothing obtained from openai)
  • superset-frontend/src/dashboard/components/Header/Header.test.tsx (nothing obtained from openai)
  • superset-frontend/src/explore/actions/exploreActions.test.js (nothing obtained from openai)
  • superset-frontend/src/components/PageHeaderWithActions/index.tsx (nothing obtained from openai)
  • superset-frontend/src/components/MetadataBar/MetadataBar.tsx (nothing obtained from openai)
  • superset-frontend/src/explore/actions/saveModalActions.js (nothing obtained from openai)
  • superset-frontend/src/explore/actions/saveModalActions.test.js (nothing obtained from openai)
  • superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx (nothing obtained from openai)
  • superset-frontend/src/explore/reducers/exploreReducer.js (nothing obtained from openai)
  • superset-frontend/src/features/datasets/types.ts (nothing obtained from openai)
  • superset-frontend/src/features/tags/BulkTagModal.tsx (nothing obtained from openai)
  • superset-frontend/src/features/tags/TagModal.test.tsx (nothing obtained from openai)
  • superset-frontend/src/features/tags/TagModal.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/AlertReportList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/AnnotationLayerList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/AllEntities/index.tsx (nothing obtained from openai)
  • superset-frontend/src/features/tags/tags.ts (nothing obtained from openai)
  • superset-frontend/src/pages/AnnotationList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/DatabaseList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/ChartCreation/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/CssTemplateList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/ChartList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/DashboardList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/DatasetList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/SavedQueryList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/QueryHistoryList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/Tags/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/ExecutionLogList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/pages/RowLevelSecurityList/index.tsx (nothing obtained from openai)
  • superset-frontend/src/views/CRUD/types.ts (nothing obtained from openai)
  • superset/app.py (nothing obtained from openai)
  • superset/cli/viz_migrations.py (nothing obtained from openai)
  • superset/async_events/async_query_manager_factory.py (nothing obtained from openai)
  • superset/async_events/api.py (nothing obtained from openai)
  • superset/charts/data/api.py (nothing obtained from openai)
  • superset/common/query_context_factory.py (nothing obtained from openai)
  • superset/dashboards/schemas.py (nothing obtained from openai)
  • superset/datasets/api.py (nothing obtained from openai)
  • superset/connectors/sqla/models.py (nothing obtained from openai)
  • superset/daos/tag.py (nothing obtained from openai)
  • superset/config.py (nothing obtained from openai)
  • superset/connectors/sqla/views.py (nothing obtained from openai)
  • superset/datasets/commands/duplicate.py (nothing obtained from openai)
  • superset/db_engine_specs/clickhouse.py (nothing obtained from openai)
  • superset/db_engine_specs/elasticsearch.py (nothing obtained from openai)
  • superset/datasets/schemas.py (nothing obtained from openai)
  • superset/db_engine_specs/README.md (nothing obtained from openai)
  • superset/db_engine_specs/base.py (nothing obtained from openai)
  • superset/db_engine_specs/kusto.py (nothing obtained from openai)
  • superset/initialization/init.py (nothing obtained from openai)
  • superset/extensions/ssh.py (nothing obtained from openai)
  • superset/db_engine_specs/solr.py (nothing obtained from openai)
  • superset/extensions/init.py (nothing obtained from openai)
  • superset/db_engine_specs/lib.py (nothing obtained from openai)
  • superset/migrations/versions/2023-06-08_09-02_9ba2ce3086e5_migrate_pivot_table_v1_to_v2.py (nothing obtained from openai)
  • superset/migrations/versions/2022-07-07_14-00_06e1e70058c7_migrating_legacy_area.py (nothing obtained from openai)
  • superset/migrations/shared/migrate_viz/base.py (nothing obtained from openai)
  • superset/migrations/versions/2023-06-08_10-22_4c5da39be729_migrate_treemap_chart.py (nothing obtained from openai)
  • superset/migrations/versions/2022-07-07_13-00_c747c78868b6_migrating_legacy_treemap.py (nothing obtained from openai)
  • superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py (nothing obtained from openai)
  • superset/migrations/versions/2023-09-15_12-58_4b85906e5b91_add_on_delete_cascade_for_dashboard_roles.py (nothing obtained from openai)
  • superset/migrations/versions/2023-08-09_14-17_8ace289026f3_add_on_delete_cascade_for_dashboard_slices.py (nothing obtained from openai)
  • superset/models/dashboard.py (nothing obtained from openai)
  • superset/migrations/versions/2023-08-09_15-39_4448fa6deeb1__dd_on_delete_cascade_for_embedded_dashboards.py.py (nothing obtained from openai)
  • superset/migrations/versions/2023-09-06_13-18_317970b4400c_added_time_secondary_column_to_.py (nothing obtained from openai)
  • superset/migrations/versions/2023-06-08_11-34_ae58e1e58e5c_migrate_dual_line_to_mixed_chart.py (nothing obtained from openai)
  • superset/models/helpers.py (nothing obtained from openai)
  • superset/sqllab/utils.py (nothing obtained from openai)
  • superset/security/manager.py (nothing obtained from openai)
  • superset/sql_parse.py (nothing obtained from openai)
  • superset/tags/commands/create.py (nothing obtained from openai)
  • superset/tags/api.py (nothing obtained from openai)
  • superset/tags/exceptions.py (nothing obtained from openai)
  • superset/tasks/cron_util.py (nothing obtained from openai)
  • superset/tasks/scheduler.py (nothing obtained from openai)
  • superset/utils/class_utils.py (nothing obtained from openai)
  • superset/tags/commands/utils.py (nothing obtained from openai)
  • superset/tags/schemas.py (nothing obtained from openai)
  • superset/views/datasource/schemas.py (nothing obtained from openai)
  • superset/utils/core.py (nothing obtained from openai)
  • superset/views/datasource/views.py (nothing obtained from openai)
  • superset/utils/machine_auth.py (nothing obtained from openai)
  • tests/integration_tests/charts/data/api_tests.py (nothing obtained from openai)
  • superset/views/core.py (nothing obtained from openai)
  • tests/integration_tests/dashboard_utils.py (nothing obtained from openai)
  • tests/integration_tests/fixtures/importexport.py (nothing obtained from openai)
  • tests/integration_tests/datasets/api_tests.py (nothing obtained from openai)
  • tests/integration_tests/core_tests.py (nothing obtained from openai)
  • tests/integration_tests/datasource_tests.py (nothing obtained from openai)
  • tests/integration_tests/datasets/commands_tests.py (nothing obtained from openai)
  • tests/unit_tests/datasets/commands/export_test.py (nothing obtained from openai)
  • tests/integration_tests/sql_lab/api_tests.py (nothing obtained from openai)
  • tests/integration_tests/test_app.py (nothing obtained from openai)
  • tests/integration_tests/security/row_level_security_tests.py (nothing obtained from openai)
  • tests/unit_tests/tasks/test_cron_util.py (diff tokens exceeds limit)
  • tests/integration_tests/tags/api_tests.py (nothing obtained from openai)
  • tests/unit_tests/dao/tag_test.py (nothing obtained from openai)
  • tests/unit_tests/sql_parse_tests.py (nothing obtained from openai)
  • tests/unit_tests/tags/commands/create_test.py (nothing obtained from openai)
  • tests/unit_tests/utils/test_core.py (nothing obtained from openai)
  • tests/unit_tests/tags/commands/update_test.py (nothing obtained from openai)
Files not reviewed due to errors (125)
  • RESOURCES/INTHEWILD.md (no response)
  • CONTRIBUTING.md (no response)
  • .github/workflows/ai-pr-reviewer.yml (no response)
  • CHANGELOG.md (no response)
  • Dockerfile (no response)
  • .gitignore (no response)
  • docs/docs/contributing/hooks-and-linting.mdx (no response)
  • docs/docs/databases/snowflake.mdx (no response)
  • docs/docs/installation/configuring-superset.mdx (no response)
  • docker/nginx/nginx.conf (no response)
  • docs/docs/installation/installing-superset-using-docker-compose.mdx (no response)
  • helm/superset/README.md (no response)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.jsx (no response)
  • superset-frontend/src/SqlLab/components/HighlightedSql/HighlightedSql.test.tsx (no response)
  • setup.py (no response)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/index.tsx (no response)
  • requirements/base.txt (no response)
  • superset-frontend/src/SqlLab/components/QueryStateLabel/QueryStateLabel.test.tsx (no response)
  • superset-frontend/src/components/Datasource/DatasourceModal.tsx (no response)
  • superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx (no response)
  • superset-frontend/src/components/MetadataBar/ContentType.ts (no response)
  • superset-frontend/src/components/Datasource/DatasourceEditor.jsx (no response)
  • superset-frontend/src/components/MetadataBar/ContentConfig.tsx (no response)
  • superset-frontend/src/components/ListView/ListView.tsx (no response)
  • superset-frontend/src/explore/actions/exploreActions.test.js (no response)
  • superset-frontend/src/components/MetadataBar/MetadataBar.tsx (no response)
  • superset-frontend/src/dashboard/components/Header/Header.test.tsx (no response)
  • superset-frontend/src/components/Tags/Tag.tsx (no response)
  • superset-frontend/src/explore/actions/saveModalActions.js (no response)
  • superset-frontend/src/components/PageHeaderWithActions/index.tsx (no response)
  • superset-frontend/src/features/tags/TagModal.test.tsx (no response)
  • superset-frontend/src/features/datasets/types.ts (no response)
  • superset-frontend/src/explore/reducers/exploreReducer.js (no response)
  • superset-frontend/src/explore/actions/saveModalActions.test.js (no response)
  • superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx (no response)
  • superset-frontend/src/features/tags/BulkTagModal.tsx (no response)
  • superset-frontend/src/pages/AnnotationList/index.tsx (no response)
  • superset-frontend/src/pages/AnnotationLayerList/index.tsx (no response)
  • superset-frontend/src/features/tags/tags.ts (no response)
  • superset-frontend/src/features/tags/TagModal.tsx (no response)
  • superset-frontend/src/pages/AllEntities/index.tsx (no response)
  • superset-frontend/src/pages/AlertReportList/index.tsx (no response)
  • superset-frontend/src/pages/CssTemplateList/index.tsx (no response)
  • superset-frontend/src/pages/ChartCreation/index.tsx (no response)
  • superset-frontend/src/pages/ChartList/index.tsx (no response)
  • superset-frontend/src/pages/DashboardList/index.tsx (no response)
  • superset-frontend/src/pages/DatabaseList/index.tsx (no response)
  • superset-frontend/src/pages/DatasetList/index.tsx (no response)
  • superset-frontend/src/pages/Tags/index.tsx (no response)
  • superset-frontend/src/pages/RowLevelSecurityList/index.tsx (no response)
  • superset-frontend/src/pages/ExecutionLogList/index.tsx (no response)
  • superset-frontend/src/pages/SavedQueryList/index.tsx (no response)
  • superset-frontend/src/pages/QueryHistoryList/index.tsx (no response)
  • superset-frontend/src/views/CRUD/types.ts (no response)
  • superset/charts/data/api.py (no response)
  • superset/app.py (no response)
  • superset/cli/viz_migrations.py (no response)
  • superset/common/query_context_factory.py (no response)
  • superset/async_events/api.py (no response)
  • superset/async_events/async_query_manager_factory.py (no response)
  • superset/daos/tag.py (no response)
  • superset/config.py (no response)
  • superset/connectors/sqla/models.py (no response)
  • superset/datasets/api.py (no response)
  • superset/dashboards/schemas.py (no response)
  • superset/connectors/sqla/views.py (no response)
  • superset/db_engine_specs/base.py (no response)
  • superset/db_engine_specs/clickhouse.py (no response)
  • superset/datasets/schemas.py (no response)
  • superset/db_engine_specs/elasticsearch.py (no response)
  • superset/datasets/commands/duplicate.py (no response)
  • superset/db_engine_specs/README.md (no response)
  • superset/db_engine_specs/lib.py (no response)
  • superset/db_engine_specs/solr.py (no response)
  • superset/db_engine_specs/kusto.py (no response)
  • superset/extensions/ssh.py (no response)
  • superset/extensions/init.py (no response)
  • superset/initialization/init.py (no response)
  • superset/migrations/versions/2023-03-27_12-30_7e67aecbf3f1_chart_ds_constraint.py (no response)
  • superset/migrations/versions/2022-07-07_14-00_06e1e70058c7_migrating_legacy_area.py (no response)
  • superset/migrations/shared/migrate_viz/base.py (no response)
  • superset/migrations/versions/2022-07-07_13-00_c747c78868b6_migrating_legacy_treemap.py (no response)
  • superset/migrations/versions/2023-06-08_09-02_9ba2ce3086e5_migrate_pivot_table_v1_to_v2.py (no response)
  • superset/migrations/versions/2023-06-08_10-22_4c5da39be729_migrate_treemap_chart.py (no response)
  • superset/migrations/versions/2023-08-09_15-39_4448fa6deeb1__dd_on_delete_cascade_for_embedded_dashboards.py.py (no response)
  • superset/migrations/versions/2023-09-06_13-18_317970b4400c_added_time_secondary_column_to_.py (no response)
  • superset/migrations/versions/2023-06-08_11-34_ae58e1e58e5c_migrate_dual_line_to_mixed_chart.py (no response)
  • superset/migrations/versions/2023-08-09_14-17_8ace289026f3_add_on_delete_cascade_for_dashboard_slices.py (no response)
  • superset/models/dashboard.py (no response)
  • superset/migrations/versions/2023-09-15_12-58_4b85906e5b91_add_on_delete_cascade_for_dashboard_roles.py (no response)
  • superset/sqllab/utils.py (no response)
  • superset/tags/api.py (no response)
  • superset/models/helpers.py (no response)
  • superset/security/manager.py (no response)
  • superset/sql_parse.py (no response)
  • superset/tags/commands/create.py (no response)
  • superset/tags/schemas.py (no response)
  • superset/tasks/cron_util.py (no response)
  • superset/tags/commands/utils.py (no response)
  • superset/tags/exceptions.py (no response)
  • superset/tasks/scheduler.py (no response)
  • superset/utils/class_utils.py (no response)
  • superset/utils/core.py (no response)
  • superset/views/datasource/views.py (no response)
  • superset/views/datasource/schemas.py (no response)
  • superset/utils/machine_auth.py (no response)
  • superset/views/core.py (no response)
  • tests/integration_tests/charts/data/api_tests.py (no response)
  • tests/integration_tests/datasets/commands_tests.py (no response)
  • tests/integration_tests/fixtures/importexport.py (no response)
  • tests/integration_tests/core_tests.py (no response)
  • tests/integration_tests/datasets/api_tests.py (no response)
  • tests/integration_tests/datasource_tests.py (no response)
  • tests/integration_tests/dashboard_utils.py (no response)
  • tests/integration_tests/test_app.py (no response)
  • tests/integration_tests/security/row_level_security_tests.py (no response)
  • tests/unit_tests/datasets/commands/export_test.py (no response)
  • tests/integration_tests/tags/api_tests.py (no response)
  • tests/unit_tests/dao/tag_test.py (no response)
  • tests/integration_tests/sql_lab/api_tests.py (no response)
  • tests/unit_tests/utils/test_core.py (no response)
  • tests/unit_tests/sql_parse_tests.py (no response)
  • tests/unit_tests/tags/commands/update_test.py (no response)
  • tests/unit_tests/tags/commands/create_test.py (no response)
  • tests/unit_tests/tasks/test_cron_util.py (no response)
Review comments generated (0)
  • Review: 0
  • LGTM: 0
Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

eschutho
eschutho commented Oct 3, 2023
View reviewed changes
superset-frontend/src/components/ListView/ListView.tsx
addDangerToast={addDangerToast}
onHide={() => setShowBulkTagModal(false)}
/>
)}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coderabbitai can you write a test for this block?

@eschutho eschutho closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.