Add Swift 5.2 support #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text initial state change
djbe
requested changes
May 21, 2020
| @@ -95,7 +95,7 @@ extension Filters.Strings { | |||
| while idx < scalars.endIndex, let scalar = UnicodeScalar(scalars[idx].value), characterSet.contains(scalar) { | |||
| idx = scalars.index(after: idx) | |||
| } | |||
| if idx > scalars.index(after: start) && idx < scalars.endIndex, | |||
| if idx < scalars.endIndex, idx > scalars.index(after: start), | |||
There was a problem hiding this comment.
I'm assuming this fixes the crash?
| @@ -79,7 +79,7 @@ class CallNodeTests: XCTestCase { | |||
| } | |||
|
|
|||
| func testRenderFail() { | |||
| let context = Context(dictionary: [:]) | |||
| let context = Context(dictionary: ["": ""]) | |||
There was a problem hiding this comment.
Why is this needed? (same for the lines below)
| @@ -7,7 +7,7 @@ let package = Package( | |||
| .library(name: "StencilSwiftKit", targets: ["StencilSwiftKit"]) | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/stencilproject/Stencil.git", .upToNextMinor(from: "0.13.0")) | |||
| .package(url: "https://github.com/stencilproject/Stencil.git", .branch("master")) | |||
There was a problem hiding this comment.
I'd rather avoid this if possible, I can probably push through a Stencil release if needed.
Do we have Swift 5 support in Stencil yet? (it's been a while)
| @@ -0,0 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Pretty sure we should add this folder to gitignore.
|
Thank you for your contribution. I know it's been a while, and in the mean time, this has been superseded by #127, which (amongst other things) adds support for Swift 5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log