-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Stencil 0.14.0 (and Swift 5) #127
Conversation
The build is failing due to |
Mmmh interesting, I got a very similar error in CircleCI for a completely different project and repo at work. Maybe CircleCI is being unstable recently about that? 🤔 Another reason might be if CircleCI updated something inside the VM images (like the version of bundler or the absolute path where the project is cloned inside the VM, changing the path of the cache being restored) without telling us…? Two things to try:
I'll take care of trying both options in a minute. |
@fortmarek Although unlikely, this might also be because you're using a fork and not the main repo. |
Thanks for looking into it so quickly @AliSoftware! The fork could be why this is happening, but it seems I have not been added to core contributors - at least I don't see myself being part of the organization and I can not create a new branch in the repo itself. |
Ah, right, I've added you to the |
Ok, seems CI is working again. Some jobs are still failing, but for good reason now (found 1 violation during lint, and compile error on usage of |
@fortmarek If you need to update the Xcode version for your build to work, you'll also need to change line 12 of |
This reverts commit 4b5c5a8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small nits and questions (but looks good overall!)
Just received an email from CircleCI about docker rate-limiting coming soon, and was wondering if there's any risk affecting us with our use of Docker in this PR…
@fortmarek you seem to be more versed into Docker than I am, any idea of the potential impact for us here? |
I believe the new Docker restrictions are OK as they limit the number of free anonymous pulls - but that's something we should not be doing very often, so I think we're fine |
Never mind, just found your dockerfile: I've made a repo to manage our docker image, and automate the build&push process to docker: https://github.com/SwiftGen/swift-docker. It's slightly based on @fortmarek with some other things I've found. In the process, I created a SwiftGen docker organisation, so now we can have docker access tokens and never worry about usage limits. |
That's the reason indeed. See this comment thread above for more context 😉
Great! Just one thing to be aware of tho, given the authentication phase you added in our CI config uses secret env vars, that means that the CI won't be able to run and authenticate on forks (on which CI secrets are not available, for security reasons), right? Not sure if that was already the case before or not. but worth to keep in mind |
Yeah the secrets aren't shared to forks, but shouldn't matter for such an "internal" repository. (talking about the docker repo) The access tokens in CircleCI are set at a "team" level. I'm not 100% sure how that works with forks, this is what the docs say:
So seems like it'll only be used when we trigger the builds? Not that it really matters anyway, like @fortmarek mentioned, we wont be triggering too many builds on this repository. |
Ok. sgtm! |
Thanks for taking this over the finish line @djbe! I've been swarmed with other stuff and couldn't get to it. Creating a new docker repo inside |
Since Stencil has a new release, it'd be great to update it for
StencilSwiftKit
, too!Apart from updating the version in
Package.swift
, some minor changes have been necessary