Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cran warnings about packages #5

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

mihai-sysbio
Copy link
Member

This PR aims to resolve the CRAN warning about the 2 packages that are not yet available on CRAN. Once they are, the 2 suggested packages should be added back.

note: pinging @mro100 about this as well

@mro100 mro100 merged commit f18c911 into main Oct 5, 2022
@mihai-sysbio mihai-sysbio deleted the fix/cran-comments-2.2.1 branch October 5, 2022 14:34
@mihai-sysbio mihai-sysbio restored the fix/cran-comments-2.2.1 branch October 5, 2022 19:56
@mihai-sysbio
Copy link
Member Author

Based on the latest build log from CRAN there is still one pending warning (locally reported as error):

* checking dependencies in R code ... WARNING
‘::’ or ‘:::’ imports not declared from:
  ‘clpAPI’ ‘cplexAPI’

It seems these 2 packages should be listed as imports in the DESCRIPTION file. However, these packages seem to have been archived long ago, so importing them would be of any help:

Given that sybil is risking archiving as well, is there any way out short of purging the use of these packages?

@mro100
Copy link
Collaborator

mro100 commented Oct 6, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants