Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove grRules from pseudoreactions #145

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

BenjaSanchez
Copy link
Contributor

Main improvements in this PR:

Pseudoreactions should not have any grRules as they are not real metabolic reactions. Function removeUnusedGenes.m from COBRA was used after removing both grRules.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected devel as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

Pseudoreactions should not have any grRules as they are not real metabolic reactions
@BenjaSanchez BenjaSanchez added the bug something is wrong in the model label Aug 7, 2018
@BenjaSanchez BenjaSanchez self-assigned this Aug 7, 2018
@BenjaSanchez BenjaSanchez merged commit 2b60dd2 into devel Aug 8, 2018
@BenjaSanchez BenjaSanchez mentioned this pull request Aug 8, 2018
@BenjaSanchez BenjaSanchez deleted the fix/pseudoreactions branch August 18, 2018 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is wrong in the model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants