refactor: card image demo grid #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
wesleyboar
changed the title
wesleyboar
commented
Jan 10, 2024
Comment on lines
33
to
31
| .card--image-top { | ||
| [class*="card--image-top"] { |
There was a problem hiding this comment.
The .card--image-top had no effect, because demo uses longhand classes (.c-card .c-card--…) not shorthand classes.
Comment on lines
-14
to
16
| #image-cards { | ||
| grid-template-columns: 1fr 1fr; | ||
| .s-image-grid { | ||
| --max-cols: 2; | ||
| } |
There was a problem hiding this comment.
I think s-image-grid achieves the goal with less demo code.
There was a problem hiding this comment.
An id must be unique in the whole document. I replaced it with an existing class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
c-card--imagesRelated
Changes
s-image-gridnoto-grids-gridTesting
UI