-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: card image demo grid #296
Conversation
.card--image-top { | ||
[class*="card--image-top"] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .card--image-top
had no effect, because demo uses longhand classes (.c-card .c-card--…
) not shorthand classes.
#image-cards { | ||
grid-template-columns: 1fr 1fr; | ||
.s-image-grid { | ||
--max-cols: 2; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think s-image-grid
achieves the goal with less demo code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An id
must be unique in the whole document. I replaced it with an existing class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Overview
c-card--images
Related
Changes
s-image-grid
noto-grid
s-grid
Testing
UI