Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: card image demo grid #296

Merged
merged 7 commits into from
Jan 10, 2024
Merged

refactor: card image demo grid #296

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d116ff9
refactor: contact card demo grid
wesleyboar Jan 10, 2024
e8d547c
refactor: c-card--images demo grid
wesleyboar Jan 10, 2024
cc2de98
fix: restore static image size
wesleyboar Jan 10, 2024
c744a9c
style: remove space between related styles
wesleyboar Jan 10, 2024
cd29f02
Merge branch 'main' into refactor/contact-card-demo-grid
wesleyboar Jan 10, 2024
4acd088
Merge branch 'main' into refactor/contact-card-demo-grid
wesleyboar Jan 10, 2024
c351ea1
Merge branch 'main' into refactor/contact-card-demo-grid
wesleyboar Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/components/c-card/c-card.demo.images.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 16 additions & 16 deletions src/lib/_imports/components/c-card/c-card--images.hbs
View file
Open in desktop
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An id must be unique in the whole document. I replaced it with an existing class.

Original file line number Diff line number Diff line change
@@ -1,107 +1,107 @@
<h2 id="section--null">Section (Default a.k.a Unstyled a.k.a Transparent)</h2>
<section class="o-section">
<h3>Transparent Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" }}
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
</section>

<h3>Plain Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" }}
{{> @c-card--image position="bottom" wide=true variant="plain" }}
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
</section>
</section>
<hr>
<h2 id="section--null">Section - Light</h2>
<section class="o-section o-section--style-light">
<h3>Transparent Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" }}
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
</section>

<h3>Plain Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" }}
{{> @c-card--image position="bottom" wide=true variant="plain" }}
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
</section>
</section>
<hr>
<h2 id="section--null">Section - Muted</h2>
<section class="o-section o-section--style-muted">
<h3>Transparent Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" }}
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
</section>

<h3>Plain Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" }}
{{> @c-card--image position="bottom" wide=true variant="plain" }}
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
</section>
</section>
<hr>
<h2 id="section--null">Section - Dark</h2>
<section class="o-section o-section--style-dark">
<h3>Transparent Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" }}
{{> @c-card--image position="bottom" wide=true variant="transparent" }}
{{> @c-card--image position="right" tall=true variant="transparent" }}
{{> @c-card--image position="left" tall=true variant="transparent" }}
</section>
<h3>Contact Card with Image - Transparent</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }}
</section>

<h3>Plain Card Image</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" }}
{{> @c-card--image position="bottom" wide=true variant="plain" }}
{{> @c-card--image position="right" tall=true variant="plain" }}
{{> @c-card--image position="left" tall=true variant="plain" }}
</section>
<h3>Contact Card with Image - Plain</h3>
<section class="o-section o-grid o-grid--col-min-width" id="image-cards">
<section class="o-section s-image-grid">
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }}
</section>
</section>
8 changes: 3 additions & 5 deletions src/lib/_imports/components/c-card/c-card.demo.images.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
}

/* create a two column grid (cleaner look) */
#image-cards {
grid-template-columns: 1fr 1fr;
.s-image-grid {
--max-cols: 2;
}
Comment on lines -14 to 16
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think s-image-grid achieves the goal with less demo code.


/* get rid of margin for inner-sections */
Expand All @@ -24,13 +24,11 @@ section > section {
:is(.card, .c-card, [class*="card--"]) h4 {
margin-bottom: 0.375em;
}

:is(.card, .c-card, [class*="card--"]) p {
margin-top: 0px;
margin-bottom: 10px;
}

.card--image-top {
[class*="card--image-top"] {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .card--image-top had no effect, because demo uses longhand classes (.c-card .c-card--…) not shorthand classes.

max-width: fit-content;
}

3 changes: 3 additions & 0 deletions src/lib/_imports/components/c-card/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ variants:
status: backup
- name: images
status: wip
context:
supportStyles:
- ../../assets/trumps/s-image-grid.css
- name: docs
status: ready
context:
Expand Down
Loading