-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: card image demo grid #296
Changes from 4 commits
d116ff9
e8d547c
cc2de98
c744a9c
cd29f02
4acd088
c351ea1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,107 +1,107 @@ | ||
<h2 id="section--null">Section (Default a.k.a Unstyled a.k.a Transparent)</h2> | ||
<section class="o-section"> | ||
<h3>Transparent Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" }} | ||
{{> @c-card--image position="bottom" wide=true variant="transparent" }} | ||
{{> @c-card--image position="right" tall=true variant="transparent" }} | ||
{{> @c-card--image position="left" tall=true variant="transparent" }} | ||
</section> | ||
<h3>Contact Card with Image - Transparent</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }} | ||
</section> | ||
|
||
<h3>Plain Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" }} | ||
{{> @c-card--image position="bottom" wide=true variant="plain" }} | ||
{{> @c-card--image position="right" tall=true variant="plain" }} | ||
{{> @c-card--image position="left" tall=true variant="plain" }} | ||
</section> | ||
<h3>Contact Card with Image - Plain</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }} | ||
</section> | ||
</section> | ||
<hr> | ||
<h2 id="section--null">Section - Light</h2> | ||
<section class="o-section o-section--style-light"> | ||
<h3>Transparent Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" }} | ||
{{> @c-card--image position="bottom" wide=true variant="transparent" }} | ||
{{> @c-card--image position="right" tall=true variant="transparent" }} | ||
{{> @c-card--image position="left" tall=true variant="transparent" }} | ||
</section> | ||
<h3>Contact Card with Image - Transparent</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }} | ||
</section> | ||
|
||
<h3>Plain Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" }} | ||
{{> @c-card--image position="bottom" wide=true variant="plain" }} | ||
{{> @c-card--image position="right" tall=true variant="plain" }} | ||
{{> @c-card--image position="left" tall=true variant="plain" }} | ||
</section> | ||
<h3>Contact Card with Image - Plain</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }} | ||
</section> | ||
</section> | ||
<hr> | ||
<h2 id="section--null">Section - Muted</h2> | ||
<section class="o-section o-section--style-muted"> | ||
<h3>Transparent Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" }} | ||
{{> @c-card--image position="bottom" wide=true variant="transparent" }} | ||
{{> @c-card--image position="right" tall=true variant="transparent" }} | ||
{{> @c-card--image position="left" tall=true variant="transparent" }} | ||
</section> | ||
<h3>Contact Card with Image - Transparent</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }} | ||
</section> | ||
|
||
<h3>Plain Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" }} | ||
{{> @c-card--image position="bottom" wide=true variant="plain" }} | ||
{{> @c-card--image position="right" tall=true variant="plain" }} | ||
{{> @c-card--image position="left" tall=true variant="plain" }} | ||
</section> | ||
<h3>Contact Card with Image - Plain</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }} | ||
</section> | ||
</section> | ||
<hr> | ||
<h2 id="section--null">Section - Dark</h2> | ||
<section class="o-section o-section--style-dark"> | ||
<h3>Transparent Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" }} | ||
{{> @c-card--image position="bottom" wide=true variant="transparent" }} | ||
{{> @c-card--image position="right" tall=true variant="transparent" }} | ||
{{> @c-card--image position="left" tall=true variant="transparent" }} | ||
</section> | ||
<h3>Contact Card with Image - Transparent</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="transparent" is-staff=true }} | ||
</section> | ||
|
||
<h3>Plain Card Image</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" }} | ||
{{> @c-card--image position="bottom" wide=true variant="plain" }} | ||
{{> @c-card--image position="right" tall=true variant="plain" }} | ||
{{> @c-card--image position="left" tall=true variant="plain" }} | ||
</section> | ||
<h3>Contact Card with Image - Plain</h3> | ||
<section class="o-section o-grid o-grid--col-min-width" id="image-cards"> | ||
<section class="o-section s-image-grid"> | ||
{{> @c-card--image position="top" wide=true variant="plain" is-staff=true }} | ||
</section> | ||
</section> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,8 @@ | |
} | ||
|
||
/* create a two column grid (cleaner look) */ | ||
#image-cards { | ||
grid-template-columns: 1fr 1fr; | ||
.s-image-grid { | ||
--max-cols: 2; | ||
} | ||
Comment on lines
-14
to
16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
|
||
/* get rid of margin for inner-sections */ | ||
|
@@ -24,13 +24,11 @@ section > section { | |
:is(.card, .c-card, [class*="card--"]) h4 { | ||
margin-bottom: 0.375em; | ||
} | ||
|
||
:is(.card, .c-card, [class*="card--"]) p { | ||
margin-top: 0px; | ||
margin-bottom: 10px; | ||
} | ||
|
||
.card--image-top { | ||
[class*="card--image-top"] { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
max-width: fit-content; | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An
id
must be unique in the whole document. I replaced it with an existing class.