fix: retryable streaming server errors to be logged as debug #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
deniseli
reviewed
Jul 9, 2024
jonathanj-square
force-pushed
the
jonathanj/issue_2002
branch
from
9bd1215
to
3d62ebe
Compare
deniseli
approved these changes
Jul 10, 2024
internal/rpc/rpc.go
Outdated
| @@ -240,7 +240,9 @@ func RetryStreamingServerStream[Req, Resp any]( | |||
| } else { | |||
| // Stream terminated; check if this was caused by an error | |||
| err = stream.Err() | |||
| logLevel = log.Warn | |||
| if !useDebugErrorLevel(err) { | |||
There was a problem hiding this comment.
For readability, could we refactor this to logLevel = logLevelForError(err)? That way, you don't need to mentally parse the ! and the variable scope/flow.
deniseli
reviewed
Jul 10, 2024
| @@ -268,3 +268,12 @@ func RetryStreamingServerStream[Req, Resp any]( | |||
|
|
|||
| } | |||
| } | |||
|
|
|||
| // useDebugErrorLevel indicates whether the specified error should be reported as a debug | |||
There was a problem hiding this comment.
nit: would you mind making a quick followup PR to fix this comment? Thanks! :)
deniseli
reviewed
Jul 10, 2024
| // useDebugErrorLevel indicates whether the specified error should be reported as a debug | ||
| // level log. | ||
| func logLevelForError(err error) log.Level { | ||
| if err != nil && strings.Contains(err.Error(), "connect: connection refused") { |
There was a problem hiding this comment.
It's better to use errors.Is for this check, like: https://go.dev/play/p/M0X4W1wcSQn
Sorry I missed this earlier!
jonathanj-square
added a commit
that referenced
this pull request
Jul 23, 2024
applying feedback from: #2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2002
unexpected warnings caused by retryable errors - retryable errors will continue to be reported as debug.