Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update comment and use better error matching scheme #2041

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: update comment and use better error matching scheme #2041

merged 1 commit into from
Jul 23, 2024

Conversation

jonathanj-square
Copy link
Contributor

applying feedback from: #2019

@jonathanj-square jonathanj-square requested review from alecthomas and a team as code owners July 10, 2024 23:14
@jonathanj-square jonathanj-square requested review from matt2e and removed request for a team July 10, 2024 23:14
@ftl-robot ftl-robot mentioned this pull request Jul 10, 2024
Open
@wesbillman
Copy link
Member

@jonathanj-square is this one good to merge in?

@jonathanj-square jonathanj-square merged commit a2923d1 into main Jul 23, 2024
59 checks passed
@jonathanj-square jonathanj-square deleted the jonathanj/pr_revisit branch July 23, 2024 22:30
@matt2e matt2e added the approved Marks an already closed PR as approved label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas alecthomas is a code owner

@matt2e matt2e Awaiting requested review from matt2e matt2e is a code owner automatically assigned from TBD54566975/ftl-reviewers

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonathanj-square @wesbillman @deniseli @matt2e