Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] Add Tag button in "Search Tag" window when Tag cannot be found by the app #1

Closed
Maxello1 opened this issue Apr 22, 2024 · 7 comments · Fixed by #262
Closed
Labels
TagStudio: Tags Relating to the TagStudio tag system Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience

Comments

@Maxello1
Copy link

example image

Untitled-1

@CyanVoxel CyanVoxel added Type: Enhancement New feature or request good first issue Good for newcomers labels Apr 22, 2024
@LunaLorea
Copy link

What about, instead of a "new" button (or maybe in addition?), whenever you type something in the search box that does not exist yet, there is a suggestion in the scroll view, asking if you want to add your search entry as a new Tag. And also you could add a new Tag just by hitting enter.

@Maxello1
Copy link
Author

good idea, would need to have a "workaround" for the color tag tho (the "on enter press" option i guess)

@LennartCode
Copy link
Contributor

And also you could add a new Tag just by hitting enter.

(Under the premise I didn't misunderstand anything)
I would advice against automatically adding a tag if a non-existent tag name is typed and enter is pressed afterwards.
If the user made a typo and just wanted to add an existing tag, this would add the wrong tag, often without the user noticing. This can lead to mislabelled data and even if the user realised the mistake, they would need to remove the tag from the file and depending on the implementation delete the tag with the typo altogether, leading to terrible UX in the best and terrible meta-data in the worst case.

@LunaLorea
Copy link

LunaLorea commented Apr 24, 2024

@LennartCode
I think this can be easily addressed by good highlighting and a 'do you really want to add this new tag'.
But also this is a feature that is common and seems to work (at least for me). For an example see the 'open or create file' dialogue in obsidian (ctrl + o).

In any case, I see your concern but I think having a keyboard shortcut to add a new tag is important since it makes using the app so much more comfortable.

@CyanVoxel
Copy link
Member

Having an extra dialog confirmation, as well as being able to edit extra information about the tag besides just the name, I think is a good way to go about it. As well as keeping the ability to do it all via the keyboard so you don't lose that flow.

CyanVoxel pushed a commit that referenced this issue Apr 26, 2024
xarvex referenced this issue in TagStudioDev/TagStudioRusted Apr 27, 2024
@xarvex xarvex removed the good first issue Good for newcomers label Apr 28, 2024
@CyanVoxel CyanVoxel added Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience labels Jun 3, 2024
@CyanVoxel CyanVoxel added this to the Alpha 9.3 milestone Jun 6, 2024
@CyanVoxel CyanVoxel added the TagStudio: Tags Relating to the TagStudio tag system label Jun 7, 2024
@PeterBouSaada
Copy link

You can have pressing Enter open up the tag creation menu, with the tag name populated, that way the user gets to configure other things and they have to confirm creation as well.

@Computerdores
Copy link
Collaborator

With #262 having been merged, I think this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TagStudio: Tags Relating to the TagStudio tag system Type: Enhancement New feature or request Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

7 participants