Add the ability to create tags when adding a tag to a file #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyanVoxel
added
Type: Enhancement
|
|
||
| create_button = QPushButton(self) | ||
| create_button.setFlat(True) | ||
| create_button.setText(f"Create \"{query.replace("&", "&&")}\"") |
There was a problem hiding this comment.
nit: the label "Create " is slightly misleading, because it not only creates the tag, but it also assigns it straight away
| f"border-color:{get_tag_color(ColorType.BORDER, "dark gray")};" | ||
| f"border-radius: 6px;" | ||
| f"border-style:solid;" | ||
| f"border-width: {math.ceil(1*self.devicePixelRatio())}px;" |
There was a problem hiding this comment.
what's the 1* multiplying for?
Unify the tag widget appearance and remove unnecessary "*1" multiplication.
|
I've made some changes and implemented the feedback given here as well as in #1. |
Focus the save button on the Add Tag panel. This allows the user to promptly hit enter to add the tag as-is.
Computerdores
added a commit
to Computerdores/TagStudio
that referenced
this pull request
Aug 27, 2024
…use it is made obsolete by TagStudioDev#262. This reverts commit 6c82adc.
CarterPillow
pushed a commit
to CarterPillow/TagStudio
that referenced
this pull request
Sep 7, 2024
…Dev#262) * Add the ability to create tags when adding a tag to a file. * ui: unify tag widget appearance Unify the tag widget appearance and remove unnecessary "*1" multiplication. * refactor: change some var names & add docstrings * feat: edit panel is opened before adding tag * feat(ui): focus save button on add panel Focus the save button on the Add Tag panel. This allows the user to promptly hit enter to add the tag as-is. --------- Co-authored-by: bjorn-out <b.g.out@uva.nl> Co-authored-by: Travis Abendshien <46939827+CyanVoxel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Ability to change further details for the newly created tag (like subtags) should be added. My suggestion would be to allow editing any tag in the search results by right-clicking. I tried to implement this, but did not get it to work yet.
I do believe the full tag creation modal should not pop-up by default, as this is frankly annoying when trying to tag many files manually. You can already use Ctrl + T or Cmd + T if you want to create a tag with more details, or use the aforementioned edit button once implemented.