Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] [MDB IGNORE] [NO GBP] Cargo-ordered bar signs don't come with access restrictions #8891

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

TaleStationBot
Copy link
Contributor

Original PR: tgstation/tgstation#80070

About The Pull Request

Bar signs ordered from cargo will not have an access restriction attached to them.

The barsign disassembly code has been slightly modified to accommodate this.

Why It's Good For The Game

It didn't even occur to me that bar signs had access locks on them.

Now you can establish Bargonia without begging the bartender/captain for their ID.

Changelog

🆑 Rhials
qol: Bar signs ordered from cargo will no longer be access-restricted.
/:cl:

Rhials and others added 2 commits December 2, 2023 21:51
…(#80070)

## About The Pull Request

Bar signs ordered from cargo will not have an access restriction
attached to them.

The barsign disassembly code has been slightly modified to accommodate
this.
## Why It's Good For The Game

It didn't even occur to me that bar signs had access locks on them.

Now you can establish Bargonia without begging the bartender/captain for
their ID.
## Changelog
:cl: Rhials
qol: Bar signs ordered from cargo will no longer be access-restricted.
/:cl:
@keywordlabeler keywordlabeler bot added Quality of Life Makes something easier to use (or harder to code) Upstream Mirror [DEPRECEATED] /TG/ merged a pull request, and now its a mirror. Watch as it pings commit-access. labels Dec 3, 2023
@Jolly-66 Jolly-66 merged commit ab25b82 into master Dec 6, 2023
24 checks passed
@Jolly-66 Jolly-66 deleted the upstream-merge-80070 branch December 6, 2023 14:29
github-actions bot added a commit that referenced this pull request Dec 6, 2023
TaleStationBot added a commit that referenced this pull request Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Makes something easier to use (or harder to code) Upstream Mirror [DEPRECEATED] /TG/ merged a pull request, and now its a mirror. Watch as it pings commit-access.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants