Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO GBP] Cargo-ordered bar signs don't come with access restrictions #80070

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

Rhials
Copy link
Contributor

@Rhials Rhials commented Dec 1, 2023

About The Pull Request

Bar signs ordered from cargo will not have an access restriction attached to them.

The barsign disassembly code has been slightly modified to accommodate this.

Why It's Good For The Game

It didn't even occur to me that bar signs had access locks on them.

Now you can establish Bargonia without begging the bartender/captain for their ID.

Changelog

🆑 Rhials
qol: Bar signs ordered from cargo will no longer be access-restricted.
/:cl:

@tgstation-server tgstation-server added GBP: No Update Prevent changes to the user's GBP balance from this PR Quality of Life Increasing esword damage is not a quality of life for traitors labels Dec 1, 2023
@Ghommie Ghommie merged commit 947e7f3 into tgstation:master Dec 3, 2023
21 checks passed
comfyorange added a commit that referenced this pull request Dec 3, 2023
Jolly-66 pushed a commit to TaleStation/TaleStation that referenced this pull request Dec 6, 2023
…h access restrictions (#8891)

Original PR: tgstation/tgstation#80070
-----

## About The Pull Request

Bar signs ordered from cargo will not have an access restriction
attached to them.

The barsign disassembly code has been slightly modified to accommodate
this.
## Why It's Good For The Game

It didn't even occur to me that bar signs had access locks on them.

Now you can establish Bargonia without begging the bartender/captain for
their ID.
## Changelog
:cl: Rhials
qol: Bar signs ordered from cargo will no longer be access-restricted.
/:cl:

---------

Co-authored-by: Rhials <28870487+Rhials@users.noreply.github.com>
Higgin pushed a commit to Higgin/tgstation that referenced this pull request Dec 12, 2023
…gstation#80070)

## About The Pull Request

Bar signs ordered from cargo will not have an access restriction
attached to them.

The barsign disassembly code has been slightly modified to accommodate
this.
## Why It's Good For The Game

It didn't even occur to me that bar signs had access locks on them.

Now you can establish Bargonia without begging the bartender/captain for
their ID.
## Changelog
:cl: Rhials
qol: Bar signs ordered from cargo will no longer be access-restricted.
/:cl:
Higgin pushed a commit to Higgin/tgstation that referenced this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GBP: No Update Prevent changes to the user's GBP balance from this PR Quality of Life Increasing esword damage is not a quality of life for traitors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants