Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factor out fcl; using pythonocc for collision detection #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jf---
Copy link

@jf--- jf--- commented Mar 25, 2024

Hi,

Excited to see this project!
PythonOCC these days is capable of detecting collisions, so its quite possible to factor out fcl

PS: FWIW, I maintained the fcl binding for some time and write the slicer referenced in the project

@jf---
Copy link
Author

jf--- commented Mar 25, 2024

( to properly merge this contribution requires a little bit more work on my end to weave in with the project: consider this a draft )

@Tanneguydv
Copy link
Owner

Hey @jf---
sorry I didn't notice earlier your pull request!
I will take a look to this as soon as possible, thank you :)

@Tanneguydv
Copy link
Owner

I've made some changes, I guess we could close the pull request, thank you for your contribution!!
You will see that I used the Layer Manager to deal with ais, this is probably not the best ...

@jf---
Copy link
Author

jf--- commented May 30, 2024

Hi @Tanneguydv no worries thanks for merging the PR... it was in a draft state, so I'll have a look again now that this has been merged. The IK solver that the project uses looks super interesting since it handles overstrained problems well which is neat feat. wrt AIS I'm a little rusty on this, I've worked with AIS a lot but it's been a couple of years...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants