Support for Plex Movie Scanner #82
Conversation
|
@wampa1 in the future, create a branch when submitting PR. you may want your |
| else: | ||
| logging.error('Movie [{} ({})]: Unrecognized GUID {}'.format( | ||
| movie.title, movie.year, movie.guid)) | ||
| continue | ||
| raise NotImplementedError() | ||
| # search and sync movie | ||
| try: | ||
| search = trakt.sync.search_by_id(x, id_type=provider) | ||
| search = [] | ||
| if ( provider == 'plex' ): |
There was a problem hiding this comment.
| if ( provider == 'plex' ): | |
| if provider == 'plex': | |
superfluous parens can be dropped
There was a problem hiding this comment.
If it's cool with you, I'd like to follow both of your suggestions.
I'll remove the parens (I am 99.99% a Java guy), kill this PR, and start a new one that's from a non-master branch.
I hope killing the PR and starting a new one doesn't cause you any additional concern.
Thanks again!
There was a problem hiding this comment.
you can force push to the same branch you created the pr, and PR will update. no need to create new PR.
you can also apply the suggestion from web. there's UI for that. but you want then probably git squash the commit locally (and the force push).
I think I figured out how to do a pull request. Forked it, then made the change then submit the request I guess.
This uses name and year matching to attempt to mitigate the plex movie scanner guid misalignment with Trakt's available lookups.
Hope this helps. It definitely helped me (and worked like a champ).
Eric