Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tooltips not working with shortcode #192

Merged

Conversation

Deji98
Copy link
Collaborator

@Deji98 Deji98 commented Jan 30, 2025

Description

fix tooltips not working with shortcode:
Resolved falling back to default when custom_title isn't set even though custom_title_zero and custom_title_plural is
Ensured there's a default when either or none is set

Benefits

fix #102

Possible drawbacks

Applicable issues

#102

Checklist

  • I have created a specific branch for this pull request before committing, starting off the current HEAD of development branch.
  • I'm submitting to the development, feature/hotfix/release branch. (Do not submit to the master branch!)
  • This pull request relates to a specific problem (bug or improvement).
  • I have mentioned the issue number in the pull request description text.
  • All the issues mentioned in this pull request relate to the problem I'm trying to solve.
  • The code I'm sending follows the PSR-12 coding style.

@Deji98 Deji98 requested a review from ojopaul as a code owner January 30, 2025 20:45
@Deji98 Deji98 linked an issue Jan 30, 2025 that may be closed by this pull request
@ojopaul ojopaul merged commit 5f945c2 into development Jan 31, 2025
0 of 3 checks passed
@ojopaul ojopaul deleted the fix/102-tooltips-not-working-with-the-shortcodes branch January 31, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltips not working with the shortcodes
2 participants