Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Better Form Names #117

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Exclude coverage files from git

b5cfa47
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

WIP Better Form Names #117

Exclude coverage files from git
b5cfa47
Select commit
Loading
Failed to load commit list.
GitHub Actions / JEST Tests failed Aug 1, 2024 in 0s

1815 passed, 1 failed and 2098 skipped

Tests failed

❌ reports/jest-report.xml

3914 tests were completed in 8s with 1815 passed, 1 failed and 2098 skipped.

Test suite Passed Failed Skipped Time
Ability dex utils 8✅ 597ms
Ability dex utils 8✅ 353ms
calculate min neg stat 16✅ 119ms
Dex details getters 4✅ 290ms
Dex details getters 4✅ 515ms
Dex Utils Egg Group Tests 28✅ 561ms
Dex Utils Egg Group Tests 28✅ 510ms
Dex utils function tests 23✅ 632⚪ 909ms
Dex utils function tests 23✅ 572ms
Dex utils Item getter tests 8✅ 601ms
Dex utils Item getter tests 4✅ 384ms
Dex Utils Move Getters 47✅ 2s
Dex Utils Move Getters 43✅ 2s
Dex utils Name getters 21✅ 544ms
Dex utils Name getters 20✅ 1❌ 446ms
Dex utils Nature getters 4✅ 426ms
Dex utils Nature getters 4✅ 412ms
Dex Utils Type Getters 3✅ 295ms
Dex Utils Type Getters 3✅ 465ms
Gender Ratio Converter 7✅ 69ms
getEvolutionMethodDetail 24✅ 2s
Pokedex Ability Util Test 1466✅ 733ms
Pokemon Abilities 5✅ 2s
Pokemon Abilities 5✅ 2s
undefined 9✅ 1466⚪ 619ms

❌ Dex utils Name getters

Dex utils Name getters createPokemonMap creates a map with the base name of a pokemon when available
  ✅ Dex utils Name getters createPokemonMap creates a map with the base name of a pokemon when available
Dex utils Name getters createPokemonMap creates a map with the alternate form name of a pokemon when available
  ❌ Dex utils Name getters createPokemonMap creates a map with the alternate form name of a pokemon when available
	Error: expect(received).toBe(expected) // Object.is equality
Dex utils Name getters createPokemonMap creates a map with the default form name of a problematic pokemon
  ✅ Dex utils Name getters createPokemonMap creates a map with the default form name of a problematic pokemon
Dex utils Name getters createPokemonMap throws an error if the pokemon id is invalid
  ✅ Dex utils Name getters createPokemonMap throws an error if the pokemon id is invalid
Dex utils Name getters getFormName returns the name of a pokemon form
  ✅ Dex utils Name getters getFormName returns the name of a pokemon form
Dex utils Name getters getFormName returns undefined if the pokemon id is invalid
  ✅ Dex utils Name getters getFormName returns undefined if the pokemon id is invalid
Dex utils Name getters getPokemonName returns the name of a pokemon
  ✅ Dex utils Name getters getPokemonName returns the name of a pokemon
Dex utils Name getters getPokemonName returns undefined if the pokemon id is invalid
  ✅ Dex utils Name getters getPokemonName returns undefined if the pokemon id is invalid
Dex utils Name getters getPokemonIdFromName should return 0 if name is not found
  ✅ Dex utils Name getters getPokemonIdFromName should return 0 if name is not found
Dex utils Name getters getPokemonIdFromName should return the correct id for valid names
  ✅ Dex utils Name getters getPokemonIdFromName should return the correct id for valid names
Dex utils Name getters getFormNameOfProblematicPokemon getFormNameOfProblematicPokemon returns correct form name for specified ID
  ✅ Dex utils Name getters getFormNameOfProblematicPokemon getFormNameOfProblematicPokemon returns correct form name for specified ID
Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns the correct index for a given pokemon name
  ✅ Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns the correct index for a given pokemon name
Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns -1 for an empty input
  ✅ Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns -1 for an empty input
Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns -1 for an invalid pokemon name
  ✅ Dex utils Name getters getPokemonMonsnoFromName() getPokemonMonsnoFromName() returns -1 for an invalid pokemon name
Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an array of pokemon names with length equal to the given maxMonsno
  ✅ Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an array of pokemon names with length equal to the given maxMonsno
Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an array of all pokemon names when maxMonsno is greater than the number of pokemon
  ✅ Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an array of all pokemon names when maxMonsno is greater than the number of pokemon
Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an empty array if maxMonsno is less than 0
  ✅ Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an empty array if maxMonsno is less than 0
Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an empty array if maxMonsno is not a number
  ✅ Dex utils Name getters Test getPokemonNames() getPokemonNames() returns an empty array if maxMonsno is not a number
Dex utils Name getters getPokemonFormId should return the correct index for a valid form ID
  ✅ Dex utils Name getters getPokemonFormId should return the correct index for a valid form ID
Dex utils Name getters getPokemonFormId should return -1 for an invalid form ID
  ✅ Dex utils Name getters getPokemonFormId should return -1 for an invalid form ID
Dex utils Name getters getPokemonFormId should return -1 for an invalid monsno
  ✅ Dex utils Name getters getPokemonFormId should return -1 for an invalid monsno

Annotations

Check failure on line 23 in plugins/pokedex-data-plugin/dex/name.test.js

See this annotation in the file changed.

@github-actions github-actions / JEST Tests

Dex utils Name getters ► Dex utils Name getters createPokemonMap creates a map with the alternate form name of a pokemon when available ► Dex utils Name getters createPokemonMap creates a map with the alternate form name of a pokemon when available

Failed test found in:
  reports/jest-report.xml
Error:
  Error: expect(received).toBe(expected) // Object.is equality
Raw output
Error: expect(received).toBe(expected) // Object.is equality

Expected: "Giratina"
Received: "Giratina Altered Forme"
    at Object.toBe (/home/runner/work/luminescent-team/luminescent-team/plugins/pokedex-data-plugin/dex/name.test.js:23:34)
    at Promise.then.completed (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/utils.js:293:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/utils.js:226:10)
    at _callCircusTest (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:297:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:233:3)
    at _runTestsForDescribeBlock (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:135:9)
    at _runTestsForDescribeBlock (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:130:9)
    at _runTestsForDescribeBlock (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:130:9)
    at run (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/run.js:68:3)
    at runAndTransformResultsToJestFormat (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (/home/runner/work/luminescent-team/luminescent-team/node_modules/jest-runner/build/testWorker.js:106:12)