Release 0.21.4

[TobiGr]

Changelog

App

New

• Show content metadata below the description Show content metadata below the description #5946
• Added "Show channel details" option in remote (non-local) playlists Add "Show channel details" option in remote (non-local) playlists #6309
• Added "Open in browser" option to long-press menu Add Open in browser option to long-press menu #6280

Improved

• Updated translations

Fixed

• Removed the option to download channels or playlists from the share menu Download option removed from channels/playlists #6385
• Fixed empty fragment text not centered when text longer than one line Fix empty fragment text not centered when text longer than one line #6387
• Fixed unwanted rich text formatting when pasting into the search field Fix unwanted rich text formatting when pasting #6353
• Fixed error handling in subscribe() in DownloadDialog Error handling in subscribe() in DownloadDialog #6118
• Fixed channel descriptions being out of the visible area in item lists Fixed channel description textView #6410
• Fixed rotation crash on video detail page (Rotation crash on „Video not available“ page #5941) fix Rotation crash on „Video not available“ page (#5941) #6242
• Fixed and improve setting import and export paths Fix and improve setting import and export paths #6402
• Fixed playback speed not being updated in PlayQueueAcitvity Fix playback speed not being updated in PlayQueueActivity #6421
• Fixed Play with Kodi button in Player always prompts to install Kore Fix Play with Kodi button in Player always prompts to install Kore #6429
• [Bandcamp] Fixed intent filters for some URLs Improve Bandcamp intent filters #6373
• [YouTube] Fixed broken likes in comments [YouTube] Fix broken likes in comments #6337

Development

• Use AdoptOpenJDK instead of Zulu in GitHub actions Use AdoptOpenJDK instead of Zulu in GitHub actions #6360
• Test and clean up PlayQueue Test and clean up PlayQueue #6345
• Updated Junit (f1bc4f5) and library for desugaring (6956d16)
• Upgrade PrettyTime to 5.0.1 Upgrade PrettyTime to 5.0.1 #6414
• Small code improvements Localization updates and small code improvements #6430

Extractor

New

• Add utility method getService() to Info object Design and theme issues #646

Improved

Fixed

• Fix YouTube comments like count Fix broken yt likes in comments NewPipeExtractor#628

Development

• Update setup java Trying to use popup on Android TV crashes the app. #635
• Fixed test MetaInfoTest.expectedMetaInfo Fix MetaInfoTest.expectedMetaInfo NewPipeExtractor#630
• Update Junit to 4.13.2 (TeamNewPipe/NewPipeExtractor@1ff56a8)
• Specify UTF-8 file encoding in RecordingDownloader and MockDownloader Specify UTF-8 file encoding in RecordingDownloader and MockDownloader NewPipeExtractor#644
• Fixed PeerTubeAccountExtractorTest Fix PeertubeAccountExtractorTest NewPipeExtractor#645
• Improve exception message thrown when not accepting an URL in LinkHandlerFactory#fromUrl(String url, String baseUrl) Improve exception message thrown when not accepting an URL in LinkHandlerFactory#fromUrl(String url, String baseUrl) NewPipeExtractor#638

APK for tesing

app.zip from CI

Please report only new bugs in this ticket!

Corresponding PR: #6432

[infinitewaveparticle]

Crash after changing "Content of Main Page" in Content Settings and clicking the back arrow:

Exception

• User Action: ui error
• Request: ACRA report
• Content Country: US
• Content Language: en
• App Language: en
• Service: none
• Version: 0.21.4
• OS: Linux Android 7.0 - 24

Crash log

java.lang.IllegalStateException: Fragment BookmarkFragment{b6180c6} (caac070f-8527-4f08-af29-55fc9d8bb9ab)} not attached to a context.
	at androidx.fragment.app.Fragment.requireContext(Fragment.java:805)
	at androidx.fragment.app.Fragment.getResources(Fragment.java:869)
	at androidx.fragment.app.Fragment.getString(Fragment.java:891)
	at org.schabi.newpipe.local.BaseLocalListFragment.onSharedPreferenceChanged(BaseLocalListFragment.java:257)
	at android.app.SharedPreferencesImpl$EditorImpl.notifyListeners(SharedPreferencesImpl.java:479)
	at android.app.SharedPreferencesImpl$EditorImpl.apply(SharedPreferencesImpl.java:387)
	at org.schabi.newpipe.settings.tabs.TabsManager.saveTabs(TabsManager.java:42)
	at org.schabi.newpipe.settings.tabs.ChooseTabsFragment.saveChanges(ChooseTabsFragment.java:139)
	at org.schabi.newpipe.settings.tabs.ChooseTabsFragment.onPause(ChooseTabsFragment.java:101)
	at androidx.fragment.app.Fragment.performPause(Fragment.java:2879)
	at androidx.fragment.app.FragmentStateManager.pause(FragmentStateManager.java:383)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1206)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
	at androidx.fragment.app.BackStackRecord.executePopOps(BackStackRecord.java:506)
	at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2166)
	at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1992)
	at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1947)
	at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1849)
	at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6836)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1520)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1410)

---

[opusforlife2]

@infinitewaveparticle Could you be more specific? We are unable to reproduce this. Maybe a particular tab or service is causing this issue.

[infinitewaveparticle]

@opusforlife2 What would you like me to be more specific about? I simply went through my normal Settings changes when I do a fresh install. This includes adding tabs for What's New and Bookmarks. I may have the names of the ones I added mixed up, but I add two that aren't there by default. Then I clicked the Back arrow and a crash was thrown to me. That is all I can really say, I think. Sent from ProtonMail mobile

…

-------- Original Message --------

On Jun 6, 2021, 6:07 AM, opusforlife2 wrote: ***@***.***(https://github.com/infinitewaveparticle) Could you be more specific? We are unable to reproduce this. Maybe a particular tab or service is causing this issue. — You are receiving this because you were mentioned. Reply to this email directly, [view it on GitHub](#6433 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AG56ID7BOQIC5KMAXVDRM2TTRNCHHANCNFSM46EWLDZA).

[opusforlife2]

@infinitewaveparticle If you can reproduce the crash on the current release, and see exactly which tab or tabs is/are causing the crash, then please open a new Github issue.