Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design and theme issues #646

Closed
4 of 6 tasks
TobiGr opened this issue Aug 2, 2017 · 2 comments
Closed
4 of 6 tasks

Design and theme issues #646

TobiGr opened this issue Aug 2, 2017 · 2 comments
Labels
feature request Issue is related to a feature in the app

Comments

@TobiGr
Copy link
Member

TobiGr commented Aug 2, 2017

I have found some cases where the current theme is not applied to all elements and only the light theme is displayed.

  • The item / folder picker in the settings has only a light theme (this dialog is called when the user wants to change the video / audio download path).
  • The menu in the tool bar in the about activity has only a light theme too.
  • The license dialog's content (=> the license's file) is a HTML file. Can we apply our themes to it, too? If yes I'd suggest to color the links red and maybe to not underline them.

I also found some inconsistent styles and views:

  • While the link to the about activity exists in the main activity there is no link to it in the tool bar of the downloads activity.
  • While the tool bar's text color is dark in the main, downloads and settings activities, it is white in the about activity when the light theme is applied. I think white looks better. What do you think?
    Maybe we also should change the color of the border at the bottom of the fragment's titles (ABOUT/LICENSES) to a ligth gray wich is used for the main text in the light theme.
  • The license dialogs have no separators which separate the dialog's header and footer from the main content as it's done in the settings (e.g. at preferred content language setting).
@mauriciocolli
Copy link
Contributor

I fixed some of the issues (and you fixed the file picker with the pull request), so can you mark them as fixed (strike-through or some todo list)?

@mauriciocolli mauriciocolli added the feature request Issue is related to a feature in the app label Sep 18, 2017
@TobiGr
Copy link
Member Author

TobiGr commented Sep 20, 2017

@mauriciocolli I have looked a little in the license dialog thing and I can't find a good solution to add separators to the alert dialo because we can't style the bottom section of it. Styling the license HTML files should be quite easy by reading the file and adding the stylesheet before passing it to the WebView. So a possible solution to add separators is either to set a costum title for the dialog (wich only adds one separator) or adding the separators to the HTML file.

This was referenced Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app
Projects
None yet
Development

No branches or pull requests

3 participants