You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have found some cases where the current theme is not applied to all elements and only the light theme is displayed.
The item / folder picker in the settings has only a light theme (this dialog is called when the user wants to change the video / audio download path).
The menu in the tool bar in the about activity has only a light theme too.
The license dialog's content (=> the license's file) is a HTML file. Can we apply our themes to it, too? If yes I'd suggest to color the links red and maybe to not underline them.
I also found some inconsistent styles and views:
While the link to the about activity exists in the main activity there is no link to it in the tool bar of the downloads activity.
While the tool bar's text color is dark in the main, downloads and settings activities, it is white in the about activity when the light theme is applied. I think white looks better. What do you think? Maybe we also should change the color of the border at the bottom of the fragment's titles (ABOUT/LICENSES) to a ligth gray wich is used for the main text in the light theme.
The license dialogs have no separators which separate the dialog's header and footer from the main content as it's done in the settings (e.g. at preferred content language setting).
The text was updated successfully, but these errors were encountered:
@mauriciocolli I have looked a little in the license dialog thing and I can't find a good solution to add separators to the alert dialo because we can't style the bottom section of it. Styling the license HTML files should be quite easy by reading the file and adding the stylesheet before passing it to the WebView. So a possible solution to add separators is either to set a costum title for the dialog (wich only adds one separator) or adding the separators to the HTML file.
I have found some cases where the current theme is not applied to all elements and only the light theme is displayed.
I also found some inconsistent styles and views:
Maybe we also should change the color of the border at the bottom of the fragment's titles (ABOUT/LICENSES) to a ligth gray wich is used for the main text in the light theme.
The text was updated successfully, but these errors were encountered: