Update prettytime. #5230
Merged
Update prettytime. #5230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B0pol
added
feature request
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
2 times, most recently
from
fab41b2
to
5d56d2b
Compare
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
5d56d2b
to
5f40c85
Compare
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
5f40c85
to
8ae4277
Compare
2 tasks
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
8ae4277
to
347d8a3
Compare
|
@Isira-Seneviratne Can you rebase on top of dev and see if my tests from #5358 run successfully? |
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
2 times, most recently
from
3e918b2
to
c04d503
Compare
|
@XiangRongLin tests seem to run without issues. Could you review? |
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
c04d503
to
061c4bb
Compare
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
061c4bb
to
da8b811
Compare
XiangRongLin
added
codequality
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
2 times, most recently
from
47f2b7a
to
46ce1be
Compare
|
@Stypox Codewise it looks ok to me. I did not test any changes and the unit tests are lacking. Since thats a major version bump, i'll leave it up to you to merge. |
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
46ce1be
to
872eac3
Compare
TobiGr
force-pushed
the
dev
branch
2 times, most recently
from
679bc75
to
2aeccc0
Compare
Also change the types of the relevant variables from Calendar to OffsetDateTime.
Isira-Seneviratne
force-pushed
the
Update_prettytime
branch
from
872eac3
to
74e20a8
Compare
Stypox
approved these changes
Mar 18, 2021
ghost
mentioned this pull request
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 22, 2021
…date_prettytime Update prettytime.
|
@Isira-Seneviratne could you please update Prettytime to the current version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
5.0.0.Final.APK testing
debug.zip
Due diligence