Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.21.0 #5872

Closed
6 of 7 tasks
Stypox opened this issue Mar 21, 2021 · 10 comments
Closed
6 of 7 tasks

Release 0.21.0 #5872

Stypox opened this issue Mar 21, 2021 · 10 comments

Comments

@Stypox
Copy link
Member

Stypox commented Mar 21, 2021

Changelogs

App

New

Improved

Fixed

Development

Extractor

New

Improved

Fixed

Development

TODO

APK for testing

NewPipe_0.21.0_RC3.zip

Corresponding PR: #5871

@Stypox Stypox mentioned this issue Mar 21, 2021
@Stypox Stypox pinned this issue Mar 21, 2021
@B0pol
Copy link
Member

B0pol commented Mar 22, 2021

Crash!

Steps to reproduce:

  1. Add any video to playlist
  2. Open the playlist
  3. Play the video in fullscreen
  4. Exit fullscreen

-> crash

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: FR
  • Content Language: fr-FR
  • App Language: fr_FR
  • Service: none
  • Version: 0.21.0
  • OS: Linux Android 9 - 28
Crash log

java.lang.RuntimeException: Unable to destroy activity {org.schabi.newpipe.debug.release0210/org.schabi.newpipe.MainActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.schabi.newpipe.error.ErrorPanelHelper.dispose()' on a null object reference
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:4496)
	at android.app.ActivityThread.handleDestroyActivity(ActivityThread.java:4515)
	at android.app.ActivityThread.handleRelaunchActivityInner(ActivityThread.java:4799)
	at android.app.ActivityThread.handleRelaunchActivity(ActivityThread.java:4732)
	at android.app.servertransaction.ActivityRelaunchItem.execute(ActivityRelaunchItem.java:69)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:108)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:68)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loop(Looper.java:193)
	at android.app.ActivityThread.main(ActivityThread.java:6718)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'void org.schabi.newpipe.error.ErrorPanelHelper.dispose()' on a null object reference
	at org.schabi.newpipe.fragments.BaseStateFragment.onDestroy(BaseStateFragment.java:62)
	at org.schabi.newpipe.fragments.list.BaseListFragment.onDestroy(BaseListFragment.java:96)
	at org.schabi.newpipe.fragments.list.BaseListInfoFragment.onDestroy(BaseListInfoFragment.java:77)
	at androidx.fragment.app.Fragment.performDestroy(Fragment.java:2927)
	at androidx.fragment.app.FragmentStateManager.destroy(FragmentStateManager.java:492)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1296)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2625)
	at androidx.fragment.app.FragmentManager.dispatchDestroy(FragmentManager.java:2609)
	at androidx.fragment.app.Fragment.performDestroy(Fragment.java:2922)
	at androidx.fragment.app.FragmentStateManager.destroy(FragmentStateManager.java:492)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1296)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
	at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
	at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1504)
	at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2625)
	at androidx.fragment.app.FragmentManager.dispatchDestroy(FragmentManager.java:2609)
	at androidx.fragment.app.FragmentController.dispatchDestroy(FragmentController.java:330)
	at androidx.fragment.app.FragmentActivity.onDestroy(FragmentActivity.java:365)
	at androidx.appcompat.app.AppCompatActivity.onDestroy(AppCompatActivity.java:242)
	at org.schabi.newpipe.MainActivity.onDestroy(MainActivity.java:458)
	at android.app.Activity.performDestroy(Activity.java:7403)
	at android.app.Instrumentation.callActivityOnDestroy(Instrumentation.java:1306)
	at android.app.ActivityThread.performDestroyActivity(ActivityThread.java:4481)
	... 13 more


@opusforlife2
Copy link
Collaborator

Same crash as Bopol, but Step 1 and 2 were searching for a video and opening it. So it is probably Step 4 that causes the crash, regardless of how a video is opened.

@B0pol
Copy link
Member

B0pol commented Mar 22, 2021

No because opening from trending doesn't cause a crash

@opusforlife2
Copy link
Collaborator

Hmm... then opening from a fragment, maybe?

@iamthesenate1
Copy link
Contributor

Error parsing trending page:

Exception

  • User Action: requested kiosk
  • Request: Start loading: https://www.youtube.com/feed/trending
  • Content Country: RO
  • Content Language: ro-RO
  • App Language: ro_RO
  • Service: YouTube
  • Version: 0.21.0
  • OS: Linux Android 7.1.2 - 25
Crash log

org.schabi.newpipe.extractor.exceptions.ParsingException: Could not get Trending name
	at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeTrendingExtractor.getName(YoutubeTrendingExtractor.java:84)
	at org.schabi.newpipe.extractor.kiosk.KioskInfo.getInfo(KioskInfo.java:70)
	at org.schabi.newpipe.extractor.kiosk.KioskInfo.getInfo(KioskInfo.java:58)
	at org.schabi.newpipe.util.ExtractorHelper.lambda$getKioskInfo$11(ExtractorHelper.java:183)
	at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$NbG7JFGg0N9HK-3exJNRB9r_hYY.call(lambda)
	at io.reactivex.rxjava3.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:43)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35)
	at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4813)
	at io.reactivex.rxjava3.internal.operators.single.SingleSubscribeOn$SubscribeOnObserver.run(SingleSubscribeOn.java:89)
	at io.reactivex.rxjava3.core.Scheduler$DisposeTask.run(Scheduler.java:614)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.run(ScheduledRunnable.java:65)
	at io.reactivex.rxjava3.internal.schedulers.ScheduledRunnable.call(ScheduledRunnable.java:56)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:272)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
	at java.lang.Thread.run(Thread.java:760)


@Stypox
Copy link
Member Author

Stypox commented Mar 24, 2021

I ran git bisect, the wrong switches color is caused by 731c65c

@Disqu3-mirOir-qt

This comment has been minimized.

@Stypox
Copy link
Member Author

Stypox commented Mar 24, 2021

@Disqu3-mirOir-qt see the comment above: #5872 (comment)

@Stypox
Copy link
Member Author

Stypox commented Mar 25, 2021

@Stypox
Copy link
Member Author

Stypox commented Mar 25, 2021

Release candidate 3: NewPipe_0.21.0_RC3.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants