-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sonar workflow #5844
Merged
Merged
Sonar workflow #5844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
I don't understand the result, but maybe that needs to be configured first. @XiangRongLin |
For PRs it should only show results for files that were changed. So since no code was changes, it shows that everything is perfect |
The checkstyle changes work for JDK 8, so this should be good to merge. |
@TobiGr see the initial post. another thing needs to be done first |
Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions
XiangRongLin
force-pushed
the
sonar_workflow
branch
from
March 20, 2021 12:58
eccb218
to
72818ff
Compare
Kudos, SonarCloud Quality Gate passed! |
XiangRongLin
approved these changes
Mar 20, 2021
ghost
mentioned this pull request
Apr 11, 2021
tossj
pushed a commit
to tossj/NewPipe-legacy
that referenced
this pull request
Apr 22, 2021
…rkflow Sonar workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Fixes the following issue(s)
Relies on the following changes
Due diligence