Add sonar plugin and github actions file for sonar analysis

[XiangRongLin]

What is it?

• Bugfix (user facing)
• Feature (user facing)
• Codebase improvement (dev facing)
• Meta improvement to the project (dev facing)

Description of the changes in your PR

• Add sonar plugin and github actions file for sonar analysis
• Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions

Fixes the following issue(s)

• closes [SonarQube] Add workflow file for analysis and adjust gradle file #5825

Relies on the following changes

• [SonarQube] Configure exclusions #5822 This needs to be done beforehand

Due diligence

• I read the contribution guidelines.

[XiangRongLin]

@TobiGr Do you have any idea why checkstyle fails on JDK 11?

[TobiGr]

I have no idea. Maybe the checkstyle suppressions are ignored? I changed a few lines, could you try it again after rebasing on https://github.com/TobiGr/NewPipe/tree/listHelper ?

[XiangRongLin]

does not work. I don't even need to rebase, just checking out your branch and running gradle build with jdk 11 fails.

[TobiGr]

it looks like the checkstyle-suppressions.xml is not processed correctly. All the failing checks are mentioned in that file and should be ignored.

[TobiGr]

Try this:

diff --git a/app/build.gradle b/app/build.gradle
index c75bd43178f..957597ad955 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -116,6 +116,7 @@ configurations {
 
 checkstyle {
     configFile rootProject.file('checkstyle.xml')
+    suppressionsLocation rootProject.file('checkstyle-suppressions.xml')
     ignoreFailures false
     showViolations true
     toolVersion = checkstyleVersion

[XiangRongLin]

@TobiGr That fails before even running checkstyle with: No signature of method: build_dfldf361ev1py0dzqgbyjtld3.checkstyle() is applicable for argument types: (build_dfldf361ev1py0dzqgbyjtld3$_run_closure4) values: [build_dfldf361ev1py0dzqgbyjtld3$_run_closure4@2814b9cd]

I would translate it to "no method with given parameters exists"

[TobiGr]

try also adding this:
suppressionsFileExpression checkstyle.suppressions.file
Otherwise, I don't have a plan what to do

[TobiGr]

Screw it, Do not even try that thing above. But this looks promising. you can also try to replace the value attr with the default one.

diff --git a/checkstyle.xml b/checkstyle.xml
index af8c5480f88..c1405c2ce36 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -23,7 +23,7 @@
     <!-- https://checkstyle.org/config_filters.html#SuppressionFilter -->
     <module name="SuppressionFilter">
         <property name="file" value="${org.checkstyle.sun.suppressionfilter.config}"
-                  default="checkstyle-suppressions.xml" />
+                  default="${config_loc}/checkstyle-suppressions.xml" />
         <property name="optional" value="true"/>
     </module>

[XiangRongLin]

@TobiGr Checkstyle problem is solved.

Are you sure, you set the secret corretly? It fails with unauthorized error
https://github.com/TeamNewPipe/NewPipe/pull/5835/checks?check_run_id=2115356764#step:6:57885

[TobiGr]

The auth error is probably caused by you opening the PR from a fork. Please push this branch to our repo and open another PR.
Edit: #5844

[TobiGr]

#5844 succeeded. We should work on that branch, so this pr can be closed.