Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain single branch #2

Closed
yajo opened this issue Jan 9, 2017 · 5 comments
Closed

Maintain single branch #2

yajo opened this issue Jan 9, 2017 · 5 comments

Comments

@yajo
Copy link
Contributor

yajo commented Jan 9, 2017

As stated by @lasley in #1 (comment), we should have only one branch with conditional install scripts depending on the Odoo version being installed.
@lasley
Copy link
Contributor

lasley commented Jan 9, 2017

Huzzaah!

PS. I'm just using a lot of your code in my Docker at the moment, but will begin converting soon. Found a bug or two that I'll submit upstream too as I finish testing 😄

yajo added a commit that referenced this issue Jan 10, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
241aa9b
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
b83d590
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
3b81d3c
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
68565b1
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
fcbd00d
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
b5364c9
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
993222c
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
e9096ac
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
c62329e
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
6043170
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
bd3c049
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
d915b7b
yajo added a commit that referenced this issue Jan 11, 2017
@yajo
Add build hooks and labels, prepare for fixing #2.
90b21f4
@yajo
Copy link
Contributor Author

yajo commented Jan 11, 2017

Closed in 90b21f4 (it did not close #1, but prepared it to be in the master branch). BTW I'm using now docker hub as a testing CI.

@yajo yajo closed this as completed Jan 11, 2017
@lasley
Copy link
Contributor

lasley commented Jan 11, 2017 •
edited
Loading

Is Dockerhub able to add status checks into PRs?

@yajo
Copy link
Contributor Author

yajo commented Jan 12, 2017 •
edited
Loading

i'm afraid not, that's the use case that would justify another CI indeed.

Well... I could create a tag per PR maybe, but I don't really want that.

@lasley
Copy link
Contributor

lasley commented Jan 12, 2017

Yeah tags were the only idea I could come up with too. Oh well, I'll keep working on the docker-quality-tools then, but make it more compatible with the existing hub tests instead of the duct-tape stuff going on now.

mileo referenced this issue in kmee/doodba Sep 5, 2023
@AndreMarcos
Merge pull request #2 from AndreMarcos/fix-python-path
d96dfc5 
[FIX] Run Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yajo @lasley