Fix acceptance errors of v15.0.1 #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
|
📱 New catalog for testing generated: Download |
pmartinbTEF
requested review from
jeprubio,
jdelga,
yamal-alm,
haynlo and
jeslat
pmartinbTEF
commented
Nov 6, 2024
| @@ -191,6 +191,7 @@ class ProgressButton : FrameLayout { | |||
| } | |||
| } | |||
|
|
|||
| @SuppressLint("ClickableViewAccessibility") | |||
There was a problem hiding this comment.
Talkback working properly
There was a problem hiding this comment.
Also SwitchAccess has been verified ✅
jeprubio
approved these changes
Nov 6, 2024
yamal-alm
approved these changes
Nov 6, 2024
jdelga
approved these changes
Nov 6, 2024
haynlo
approved these changes
Nov 6, 2024
jeslat
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥅 What's the goal?
Fix acceptance errors of v15.0.1. PerformClick call was causing double calls to progressButton. Also if you scroll starting from the button, lifting your finger activates the button.
🚧 How do we do it?
Deleted performClick call and added SuppressLint annotation
☑️ Checks
🧪 How can I test this?
Tested in this PR with this snapshot (15.0.1.2-SNAPSHOT)