Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix acceptance errors of v15.0.1 #395

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Fix acceptance errors of v15.0.1 #395

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1772e7
Fix acceptance errors of v15.0.1
pmartinbTEF Nov 6, 2024
e7bf4e8
Remove only performClick call
pmartinbTEF Nov 6, 2024
3dfb532
Indicate eventConsumed when MotionEvent.ACTION_UP
pmartinbTEF Nov 6, 2024
cb9f804
Remove performClick and add SuppressLint
pmartinbTEF Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/main/java/com/telefonica/mistica/button/ProgressButton.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,7 @@ class ProgressButton : FrameLayout {
}
}

@SuppressLint("ClickableViewAccessibility")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talkback working properly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also SwitchAccess has been verified ✅

private fun setButtonBackground() {
buttonBackground.apply {
id = NO_ID
Expand Down Expand Up @@ -219,7 +220,6 @@ class ProgressButton : FrameLayout {
MotionEvent.ACTION_UP, MotionEvent.ACTION_CANCEL -> {
buttonNormal.isPressed = false
buttonLoading.isPressed = false
view.performClick()
}
}
false
Expand Down
Loading