fix(markdown): render table without extra newlines above #3080
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
This PR looks to fix #3027 by adding
new_line = False
to theTableRowElement
andTableDataElement
.Currently if a markdown table contains any empty cells, an extra new line is rendered above the table for every empty cell. See the screenshot in the linked issue for an example.
These extra newlines seem to be caused by this code in
Markdown
:rich/rich/markdown.py
Lines 692 to 699 in 720800e
I confess I'm not as familiar with the Rich codebase as I am with Textual, so please let me know if I'm on the wrong track here.