fix(markdown): render table without extra newlines above

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## Unreleased
+
+### Fixed
+
+- Fixed a bug with extra space above a markdown table with empty cells https://github.com/Textualize/rich/issues/3027
+
 ## [13.7.0] - 2023-11-15
 
 ### Added

CONTRIBUTORS.md

@@ -18,6 +18,7 @@ The following people have contributed to the development of Rich:
 - [Aryaz Eghbali](https://github.com/AryazE)
 - [Oleksis Fraga](https://github.com/oleksis)
 - [Andy Gimblett](https://github.com/gimbo)
+- [Tom Gooding](https://github.com/TomJGooding)
 - [Michał Górny](https://github.com/mgorny)
 - [Nok Lam Chan](https://github.com/noklam)
 - [Leron Gray](https://github.com/daddycocoaman)

rich/markdown.py

@@ -297,6 +297,8 @@ def on_child_close(
 class TableRowElement(MarkdownElement):
     """MarkdownElement corresponding to `tr_open` and `tr_close`."""
 
+    new_line = False
+
     def __init__(self) -> None:
         self.cells: List[TableDataElement] = []
 
@@ -312,6 +314,8 @@ class TableDataElement(MarkdownElement):
     """MarkdownElement corresponding to `td_open` and `td_close`
     and `th_open` and `th_close`."""
 
+    new_line = False
+
     @classmethod
     def create(cls, markdown: "Markdown", token: Token) -> "MarkdownElement":
         style = str(token.attrs.get("style")) or ""

tests/test_markdown.py

@@ -174,6 +174,32 @@ def test_partial_table():
     assert result == expected
 
 
+def test_table_with_empty_cells():
+    """Test a table with empty cells is rendered without extra newlines above.
+
+    Regression test for #3027 https://github.com/Textualize/rich/issues/3027
+    """
+    complete_table = Markdown(
+        """\
+| First Header  | Second Header |
+| ------------- | ------------- |
+| Content Cell  | Content Cell  |
+| Content Cell  | Content Cell  |
+"""
+    )
+    table_with_empty_cells = Markdown(
+        """\
+| First Header  |               |
+| ------------- | ------------- |
+| Content Cell  | Content Cell  |
+|               | Content Cell  |
+"""
+    )
+    result = len(render(table_with_empty_cells).splitlines())
+    expected = len(render(complete_table).splitlines())
+    assert result == expected
+
+
 if __name__ == "__main__":
     markdown = Markdown(MARKDOWN)
     rendered = render(markdown)