This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Refactor: Mission Class #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separation of functions and actions
6 tasks
ccmuk58
approved these changes
Apr 10, 2023
Comment on lines
21
to
26
| OnCountChanged?.Invoke(); | ||
|
|
||
| if (_count >= _maxCount) | ||
| { | ||
| OnCountMax?.Invoke(); | ||
| } |
There was a problem hiding this comment.
이거 엄청 자주 쓰는 것 같아요 되게 좋습니다..?!
kyoonge
reviewed
Apr 11, 2023
Comment on lines
+8
to
+9
| private float _count; | ||
| private readonly float _maxCount; |
There was a problem hiding this comment.
질문 있슴니다.........
변수명 앞에 붙은 _ 이런 표시는 클래스 내에서 전역적으로 쓰일 때 붙여야 하는거야?
전역변수 private 으로 선언될 때 쓰는 규칙인가요...?
There was a problem hiding this comment.
카멜표기법이라고 부르는데 간단하게 멤버 private은 _로 구분하고 public, protected는 붙이지 않는 것
정리 잘된 블로그 글이라 이거 보며 조금 이해될거야
|
중복 코드랑 TimeLogic자체가 Counter로 사용 가능해서 삭제. |
This was
linked to
issues
Apr 11, 2023
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separation of functions and actions
기능과 행동을 분리하고.. 코드 전체적으로 다듬었습니다..