Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platforms: ihp-sg13g2: May Update #2084

Merged
merged 6 commits into from
Aug 5, 2024
Merged

platforms: ihp-sg13g2: May Update #2084

merged 6 commits into from
Aug 5, 2024

Conversation

dnltz
Copy link
Contributor

@dnltz dnltz commented Jun 26, 2024 •
edited
Loading

Picked @KrzysztofHerman update script and modified it slightly. Synced files afterwards with this script and added the bondpad manually.

Should we remove metal fill here since KLayout is supposed to do this task?

This PR is based on #2002 with some changes and addresses PR #2066

@maliberty
Copy link
Member

Part of the motivation to implement metal fill in OR was to allow future support for timing aware fill. If fill can be accomplished in OR it might be nice to keep that door open.

@dnltz
Copy link
Contributor Author

dnltz commented Jun 26, 2024

Part of the motivation to implement metal fill in OR was to allow future support for timing aware fill. If fill can be accomplished in OR it might be nice to keep that door open.

I would let @KrzysztofHerman decide whether OR should fill the core. Maybe Klayout just fills everything else?

@maliberty
Copy link
Member

If you require FEOL fill beyond the usual fill cells that would have to be done in KLayout. I'll wait on this PR for @KrzysztofHerman 's comments

@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024

If you require FEOL fill beyond the usual fill cells that would have to be done in KLayout. I'll wait on this PR for @KrzysztofHerman 's comments

I'm gonna drop this patch because not adding USE_FILL has the same result. BTW USE_FILL=0 still adds filler cells.

@dnltz dnltz force-pushed the WIP/dnltz/ihp-may-update branch from f08047a to 7406a2e Compare June 27, 2024 08:25
@dnltz dnltz mentioned this pull request Jun 27, 2024
Merged
1 task
@dnltz dnltz force-pushed the WIP/dnltz/ihp-may-update branch from 7406a2e to a10b2d9 Compare June 27, 2024 13:45
@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024 •
edited
Loading

Latest update.

@KrzysztofHerman
Copy link
Contributor

@dnltz since we have to generate very specific filler in FEOL we have to use klayout so in a case of IHP platform lests use this tool for generating all fill cells FEOL+BEOL.
As for the sg13g2.map I have already seen the changes in .lyt fila added in our dev branch. If any modifications are to be done we could handle it "on the fly", while running sg13g2_update.py script.

@dnltz
Copy link
Contributor Author

dnltz commented Jul 1, 2024

@dnltz since we have to generate very specific filler in FEOL we have to use klayout so in a case of IHP platform lests use this tool for generating all fill cells FEOL+BEOL. As for the sg13g2.map I have already seen the changes in .lyt fila added in our dev branch. If any modifications are to be done we could handle it "on the fly", while running sg13g2_update.py script.

@KrzysztofHerman I think ORFS should be synced with main and not dev. Therefore, I made this change manually to fix it in a proper way. The current solution is way cleaner ...

any concerns about this PR?

@maliberty
Copy link
Member

Does this contain RAMS as inquired about in #2099 ?

What remains in order to merge this?

@KrzysztofHerman
Copy link
Contributor

@maliberty we are waiting for some fixes in IOCells, after it is ready we can update and merge.

@maliberty
Copy link
Member

Do you have an ETA for that? If it will be a while it might be good to make a separate PR to pull in the RAMs.

@maliberty maliberty marked this pull request as draft July 3, 2024 17:35
@dnltz
Copy link
Contributor Author

dnltz commented Jul 4, 2024

@KrzysztofHerman is this something we could update later? I would like to continue with the other pull-request to finally send ElemRV...

@KrzysztofHerman
Copy link
Contributor

@dnltz since I do not have an ETA for the IOCells we can separate the abovementioned PR's.

@maliberty
Copy link
Member

Any eta for this?

@maliberty
Copy link
Member

As this PR is proceeding slowly I've opened #2171 to merge the RAM related files (only typ corner) to enable the user in #2099

@dnltz dnltz force-pushed the WIP/dnltz/ihp-may-update branch from a10b2d9 to 017d64b Compare July 25, 2024 06:39
@dnltz
Copy link
Contributor Author

dnltz commented Jul 25, 2024

As this PR is proceeding slowly I've opened #2171 to merge the RAM related files (only typ corner) to enable the user in #2099

Rebased to master and pinged @KrzysztofHerman to take a look.

@KrzysztofHerman
Copy link
Contributor

@dnltz please go ahead

@dnltz dnltz marked this pull request as ready for review July 25, 2024 15:59
@dnltz
Copy link
Contributor Author

dnltz commented Jul 25, 2024

@maliberty it failed to build an asap7 design. Still fine?

@maliberty
Copy link
Member

@maliberty it failed to build an asap7 design. Still fine?

Yes

maliberty
maliberty requested changes Jul 25, 2024
View reviewed changes
flow/platforms/ihp-sg13g2/lef/sg13g2_io_notracks.lef Outdated Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Outdated Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Outdated Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Show resolved Hide resolved
flow/platforms/ihp-sg13g2/sg13g2_update.py Show resolved Hide resolved
@dnltz dnltz force-pushed the WIP/dnltz/ihp-may-update branch 4 times, most recently from 40d5464 to 20339bc Compare July 31, 2024 11:18
dnltz added 6 commits August 2, 2024 18:04
@dnltz
flow: platforms: ihp-sg13g2: Add script to update files
94df182 
This script can download the latest Open PDK files and helps
to easily sync ORFS.

Signed-off-by: KrzysztofHerman <herman@ihp-microelectronics.com>
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
flow: platforms: ihp-sg13g2: Sync files with 5a42d03
ac47482 
IHP-GmbH/IHP-Open-PDK@5a42d03

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
flow: platforms: ihp-sg13g2: Add 70x70 bondpads
706df83 
Add manually bondpads with 70x70 dimensions since they're not
supported in the Open PDK yet.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
flow: platforms: ihp-sg13g2: Add layer map
e967960 
The layer map is missing in sg13g2.lyt and layers won't be
drawn correctly.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
flow: platforms: ihp-sg13g2: Allow sg13g2_antennanp cell
22c5e84 
Remove sg13g2_antennanp from DONT_USE_CELLS.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz
flow: Makefile: Replace .map files in do-klayout
c174af8 
IHP's PDK uses a map file to define layers. We need to alter
the path to point from the OBJECTS_DIR to the PDK dir. Add
a sed command after LEF modifications.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz dnltz force-pushed the WIP/dnltz/ihp-may-update branch from 20339bc to c174af8 Compare August 2, 2024 16:05
@dnltz
Copy link
Contributor Author

dnltz commented Aug 5, 2024

@maliberty I removed the sg13g2_io_notracks.lef file since it has no use case here.

@dnltz dnltz requested a review from maliberty August 5, 2024 12:17
@maliberty maliberty merged commit 17ce718 into The-OpenROAD-Project:master Aug 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dnltz @maliberty @KrzysztofHerman