Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flow: platforms: ihp-sg13g2: Add IO files #2090

Merged
merged 1 commit into from
Aug 6, 2024
Merged

flow: platforms: ihp-sg13g2: Add IO files #2090

merged 1 commit into from
Aug 6, 2024

Conversation

dnltz
Copy link
Contributor

@dnltz dnltz commented Jun 27, 2024 •
edited
Loading

Add all IO related lib, lef, and gds files when 'HAS_IO_RING' is set to 1. Those files will be appended to the 'ADDITIONAL_x' variables.

@dnltz
Copy link
Contributor Author

dnltz commented Jun 27, 2024

@maliberty any concerns about adding HAS_IO_RING as optional environment variable? Should I document that somewhere?

@maliberty
Copy link
Member

@maliberty any concerns about adding HAS_IO_RING as optional environment variable? Should I document that somewhere?

In order to generate a pad ring the user will need to set FOOTPRINT_TCL (or the obsolete FOOTPRINT). HAS_IO_RING seems redundant.

@dnltz
Copy link
Contributor Author

dnltz commented Jul 1, 2024

FOOTPRINT_TCL

That's even better, thanks!

@dnltz dnltz force-pushed the WIP/dnltz/ihp-optional-IO-files branch from 0392ebd to d4a23aa Compare July 1, 2024 08:25
@dnltz
Copy link
Contributor Author

dnltz commented Jul 1, 2024

@KrzysztofHerman fyi

@maliberty
Copy link
Member

This is marked as a draft - should I hold off on review?

@dnltz
Copy link
Contributor Author

dnltz commented Jul 3, 2024

This is marked as a draft - should I hold off on review?

yeah, let's start when the other PR got merged since this fails anyway

@dnltz
flow: platforms: ihp-sg13g2: Add IO files
1e09375 
Add all IO related lib, lef, and gds files when 'FOOTPRINT_TCL'
is set. Those files will be appended to the 'ADDITIONAL_x'
variables.

Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
@dnltz dnltz force-pushed the WIP/dnltz/ihp-optional-IO-files branch from d4a23aa to 1e09375 Compare August 6, 2024 09:57
@dnltz dnltz marked this pull request as ready for review August 6, 2024 10:02
@dnltz
Copy link
Contributor Author

dnltz commented Aug 6, 2024

@maliberty since all required files are on master now, this PR is ready for review :)

maliberty
maliberty approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@maliberty maliberty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to generate a non-dummy IO lib file?

@maliberty maliberty merged commit 06d9d9b into The-OpenROAD-Project:master Aug 6, 2024
6 checks passed
@dnltz
Copy link
Contributor Author

dnltz commented Aug 12, 2024

@maliberty lib files for IO cells are only available in the dev branch: https://github.com/IHP-GmbH/IHP-Open-PDK/tree/dev/ihp-sg13g2/libs.ref/sg13g2_io/lib

So, should be available with the next merge to main.

@maliberty
Copy link
Member

@dnltz will you make a PR once they are ready?

@dnltz
Copy link
Contributor Author

dnltz commented Aug 12, 2024

sure, can do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maliberty maliberty maliberty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnltz @maliberty